chore(deps): bump vite-plus to pkg-pr-new PR #1703#7
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates dependencies to use pre-release builds of vite-plus from pkg.pr.new and configures pnpm-workspace.yaml with corresponding overrides and release age settings. The feedback highlights critical risks: using temporary PR build URLs in a template package.json can cause future installation failures for users, and mismatching the PR-based catalog version with the commit-specific overrides for vite-plus could lead to compatibility issues.
| "@typescript/native-preview": "^7.0.0-dev.20260525.1", | ||
| "tailwindcss": "^4.3.0", | ||
| "vite-plus": "^0.1.22" | ||
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1703" |
There was a problem hiding this comment.
Using a temporary pkg.pr.new PR build URL in a template package.json is highly risky. Once the upstream PR is merged, closed, or the build expires, any user attempting to bootstrap a new project using create-rari-app will experience installation failures. Consider using a stable published version or a release tag for templates, or ensure this is reverted before releasing.
| rolldown: ^1.0.2 | ||
| vite: ^8.0.14 | ||
| vite-plus: ^0.1.22 | ||
| vite-plus: "https://pkg.pr.new/voidzero-dev/vite-plus@1703" |
There was a problem hiding this comment.
The vite-plus catalog entry uses the PR number (@1703), while the overrides section uses the specific commit hash (@d0b407c85b560c2470395176c9f1c838b5ca8af8). If the PR is updated with new commits, these versions could get out of sync, leading to potential compatibility issues. It is safer to pin vite-plus to the exact same commit hash as the overrides.
vite-plus: "https://pkg.pr.new/voidzero-dev/vite-plus@d0b407c85b560c2470395176c9f1c838b5ca8af8"
Summary
Bump
vite-plusand related packages to the pkg-pr-new prerelease build for upstream PR voidzero-dev/vite-plus#1703 (commit d0b407c).Test plan