Skip to content

chore(deps): bump vite-plus to pkg-pr-new pr-1588#6

Draft
fengmk2 wants to merge 2 commits into
mainfrom
update-vite-plus-prerelease-test-pr-1588
Draft

chore(deps): bump vite-plus to pkg-pr-new pr-1588#6
fengmk2 wants to merge 2 commits into
mainfrom
update-vite-plus-prerelease-test-pr-1588

Conversation

@fengmk2

@fengmk2 fengmk2 commented May 28, 2026

Copy link
Copy Markdown
Owner

Summary

Bump vite-plus to pkg-pr-new build for PR #1588 (replace @voidzero-dev/vite-plus-test with upstream vitest@4.1.5).

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vite-plus dependency and adds workspace overrides pointing to temporary pkg.pr.new URLs, alongside configuration adjustments in pnpm-workspace.yaml. The review feedback correctly highlights that using temporary PR-specific package URLs in the template package.json, workspace overrides, and catalog entries will lead to installation failures and build instability once those temporary builds expire. These dependencies must be updated to stable, registry-published versions before merging.

"@typescript/native-preview": "^7.0.0-dev.20260525.1",
"tailwindcss": "^4.3.0",
"vite-plus": "^0.1.22"
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1588"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using a temporary pkg.pr.new URL in a template package.json will cause installation failures for end-users once the temporary PR build expires or is removed. This dependency needs to be updated to a stable or pre-release version published on the npm registry prior to merging.

Comment thread pnpm-workspace.yaml
Comment on lines +22 to +23
"@voidzero-dev/vite-plus-core": https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@5577b0154f33d1480a3c96347e94fa5d2094de2e
"@voidzero-dev/vite-plus-prompts": https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@5577b0154f33d1480a3c96347e94fa5d2094de2e

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These overrides point to temporary pkg.pr.new commit builds. To prevent build instability and dependency on temporary external assets, these must be replaced with registry-published versions before merging into the main branch.

Comment thread pnpm-workspace.yaml
rolldown: ^1.0.2
vite: ^8.0.14
vite-plus: ^0.1.22
vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@1588

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This catalog entry points to a temporary pkg.pr.new build. It should be updated to a version published on the npm registry before merging to maintain long-term build stability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant