chore(deps): bump vite-plus to pkg-pr-new pr-1588#6
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the vite-plus dependency in package.json to a preview release URL and configures corresponding overrides and release age exclusions in pnpm-workspace.yaml. The reviewer recommends pinning vite-plus to the exact commit hash rather than the PR number to ensure build reproducibility and prevent version mismatches with the overridden packages.
| "tailwindcss-animate": "^1.0.7", | ||
| "typescript": "^6.0.0", | ||
| "vite-plus": "0.1.22", | ||
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1588", |
There was a problem hiding this comment.
To ensure build reproducibility and prevent potential version mismatch issues, it is highly recommended to pin vite-plus to the exact same commit hash (5577b0154f33d1480a3c96347e94fa5d2094de2e) used for the @voidzero-dev/vite-plus-core and @voidzero-dev/vite-plus-prompts overrides in pnpm-workspace.yaml.
Using the PR number @1588 means that if new commits are pushed to the PR upstream, vite-plus will resolve to the latest commit while the overrides remain pinned to the older commit, which can lead to unexpected runtime errors or out-of-sync behaviors.
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1588", | |
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@5577b0154f33d1480a3c96347e94fa5d2094de2e", |
Summary
Bump vite-plus to pkg-pr-new build for PR #1588 (replace @voidzero-dev/vite-plus-test with upstream vitest@4.1.5).
Test plan