Skip to content

chore(deps): bump vite-plus to pkg-pr-new pr-1588#6

Draft
fengmk2 wants to merge 2 commits into
mainfrom
update-vite-plus-prerelease-test-pr-1588
Draft

chore(deps): bump vite-plus to pkg-pr-new pr-1588#6
fengmk2 wants to merge 2 commits into
mainfrom
update-vite-plus-prerelease-test-pr-1588

Conversation

@fengmk2

@fengmk2 fengmk2 commented May 28, 2026

Copy link
Copy Markdown
Owner

Summary

Bump vite-plus to pkg-pr-new build for PR #1588 (replace @voidzero-dev/vite-plus-test with upstream vitest@4.1.5).

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vite-plus dependency in package.json to a preview release URL and configures corresponding overrides and release age exclusions in pnpm-workspace.yaml. The reviewer recommends pinning vite-plus to the exact commit hash rather than the PR number to ensure build reproducibility and prevent version mismatches with the overridden packages.

Comment thread package.json
"tailwindcss-animate": "^1.0.7",
"typescript": "^6.0.0",
"vite-plus": "0.1.22",
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1588",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To ensure build reproducibility and prevent potential version mismatch issues, it is highly recommended to pin vite-plus to the exact same commit hash (5577b0154f33d1480a3c96347e94fa5d2094de2e) used for the @voidzero-dev/vite-plus-core and @voidzero-dev/vite-plus-prompts overrides in pnpm-workspace.yaml.

Using the PR number @1588 means that if new commits are pushed to the PR upstream, vite-plus will resolve to the latest commit while the overrides remain pinned to the older commit, which can lead to unexpected runtime errors or out-of-sync behaviors.

Suggested change
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1588",
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@5577b0154f33d1480a3c96347e94fa5d2094de2e",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant