chore(deps): bump vite-plus to 0.1.21-alpha.7#4
Draft
fengmk2 wants to merge 2 commits into
Draft
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the vite-plus dependency to a pre-release version and adds a minimumReleaseAgeExclude section to the pnpm-workspace.yaml file. Review feedback suggests that the new configuration in pnpm-workspace.yaml is likely misplaced, as pnpm typically manages release age exceptions via .npmrc, and the current changes are inconsistent with the PR's stated goals regarding catalogs and overrides.
Comment on lines
+3
to
+5
| minimumReleaseAgeExclude: | ||
| - vite-plus | ||
| - "@voidzero-dev/*" |
There was a problem hiding this comment.
The addition of minimumReleaseAgeExclude to pnpm-workspace.yaml appears to be a misconfiguration based on the PR description and standard package manager behavior:
- Incorrect File/Key for pnpm: The PR description states this is for
pnpm. Inpnpm(v10+), the 'minimum release age' feature is configured in.npmrcusing theminimum-release-age-exceptionskey.pnpm-workspace.yamldoes not recognize this field. - Inconsistency with Summary: The PR summary mentions updating
catalogsandoverrides, but these changes are missing from the diff. If you intended to use pnpm catalogs to manage these versions, they should be defined in this file under acatalogskey. - Naming: If this is a custom field for a tool like
vite-plus, consider using the pluralminimumReleaseAgeExcludesfor consistency with the list and the alternative name mentioned in the PR description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
vite-plusand related packages to alpha 0.1.21-alpha.7.Updated where applicable:
vite-plusvitest(alias to@voidzero-dev/vite-plus-test)vite(alias to@voidzero-dev/vite-plus-core)overrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsminimumReleaseAgeExclude/minimumReleaseAgeExcludesconfigured for pnpm + bunTest plan