Skip to content

chore(deps): bump vite-plus to 0.1.21-alpha.7#4

Draft
fengmk2 wants to merge 2 commits into
mainfrom
update-vite-plus-alpha-0.1.21-alpha.7
Draft

chore(deps): bump vite-plus to 0.1.21-alpha.7#4
fengmk2 wants to merge 2 commits into
mainfrom
update-vite-plus-alpha-0.1.21-alpha.7

Conversation

@fengmk2

@fengmk2 fengmk2 commented May 13, 2026

Copy link
Copy Markdown
Owner

Summary

Bump vite-plus and related packages to alpha 0.1.21-alpha.7.

Updated where applicable:

  • vite-plus
  • vitest (alias to @voidzero-dev/vite-plus-test)
  • vite (alias to @voidzero-dev/vite-plus-core)
  • overrides / resolutions / pnpm.overrides / pnpm-workspace.yaml catalogs
  • minimumReleaseAgeExclude / minimumReleaseAgeExcludes configured for pnpm + bun

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vite-plus dependency to a pre-release version and adds a minimumReleaseAgeExclude section to the pnpm-workspace.yaml file. Review feedback suggests that the new configuration in pnpm-workspace.yaml is likely misplaced, as pnpm typically manages release age exceptions via .npmrc, and the current changes are inconsistent with the PR's stated goals regarding catalogs and overrides.

Comment thread pnpm-workspace.yaml
Comment on lines +3 to +5
minimumReleaseAgeExclude:
- vite-plus
- "@voidzero-dev/*"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The addition of minimumReleaseAgeExclude to pnpm-workspace.yaml appears to be a misconfiguration based on the PR description and standard package manager behavior:

  1. Incorrect File/Key for pnpm: The PR description states this is for pnpm. In pnpm (v10+), the 'minimum release age' feature is configured in .npmrc using the minimum-release-age-exceptions key. pnpm-workspace.yaml does not recognize this field.
  2. Inconsistency with Summary: The PR summary mentions updating catalogs and overrides, but these changes are missing from the diff. If you intended to use pnpm catalogs to manage these versions, they should be defined in this file under a catalogs key.
  3. Naming: If this is a custom field for a tool like vite-plus, consider using the plural minimumReleaseAgeExcludes for consistency with the list and the alternative name mentioned in the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant