chore: upgrade vite-plus to 0.1.19-alpha.3#1
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates vite-plus to version 0.1.19-alpha.3 and synchronizes various dependencies in the lockfile. In vite.config.ts, the linting command for staged files was modified to include the --no-error-on-unmatched-pattern flag. Feedback recommends refining the glob pattern used for linting to exclude unsupported extensions like css and md while adding missing ones such as mjs and cjs to ensure comprehensive coverage.
| staged: { | ||
| "*": "vp fmt --no-error-on-unmatched-pattern", | ||
| "*.{js,jsx,tsx,ts,mts,css,md,json,yml,vue}": "vp lint --fix", | ||
| "*.{js,jsx,tsx,ts,mts,css,md,json,yml,vue}": "vp lint --fix --no-error-on-unmatched-pattern", |
There was a problem hiding this comment.
The glob pattern for vp lint includes several file extensions (css, md, yml) that are typically not handled by the JS/TS linting plugins configured in this file (lines 51-75). Including these extensions likely triggered the need for the --no-error-on-unmatched-pattern flag because the linter would encounter files it doesn't know how to process.
Additionally, the pattern is missing common extensions like mjs, cjs, and cts, which should be included for comprehensive coverage in a modern TypeScript project. I recommend refining the glob to focus on supported file types.
| "*.{js,jsx,tsx,ts,mts,css,md,json,yml,vue}": "vp lint --fix --no-error-on-unmatched-pattern", | |
| "*.{js,jsx,mjs,cjs,tsx,ts,mts,cts,json,vue}": "vp lint --fix --no-error-on-unmatched-pattern", |
Upgrade vite-plus and related packages to 0.1.19-alpha.3 alpha version.