chore(deps): bump vite-plus to pkg-pr-new PR #1703#7
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates dependency configurations to use pre-release builds of vite-plus and its sub-packages from pkg.pr.new, and configures .npmrc to exclude these packages from minimum release age checks. The reviewer identified a potential typo or missing comma in the .npmrc exclusion list (oxlint-tsgolint) and recommended pinning the vite-plus dependency to a specific commit hash instead of the PR number in both package.json and playground/package.json to ensure build reproducibility and prevent version drift.
| @@ -1,2 +1,3 @@ | |||
| ignore-scripts=true | |||
| min-release-age=3 | |||
| min-release-age-exclude=vite-plus,@voidzero-dev/*,@oxc-project/*,@oxlint/*,oxlint,oxfmt,oxlint-tsgolint | |||
There was a problem hiding this comment.
The entry oxlint-tsgolint at the end of the exclusion list appears to be a typo or a missing comma between two separate package names (e.g., oxlint-ts and golint, or similar). Please verify and correct this to ensure the release age exclusion applies to the intended packages.
| "typescript": "^6.0.3", | ||
| "vite": "^8.0.10", | ||
| "vite-plus": "^0.1.19", | ||
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1703", |
There was a problem hiding this comment.
To ensure build reproducibility and prevent potential version mismatch issues, it is recommended to pin vite-plus to the exact commit hash (d0b407c85b560c2470395176c9f1c838b5ca8af8) rather than the PR number (1703). Currently, the overrides are pinned to the commit hash, but vite-plus is pinned to the PR number. If the PR is updated with new commits, vite-plus and its overridden sub-packages will drift out of sync.
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1703", | |
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@d0b407c85b560c2470395176c9f1c838b5ca8af8", |
| "typescript": "^6.0.3", | ||
| "vite": "^8.0.3", | ||
| "vite-plus": "^0.1.19", | ||
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1703", |
There was a problem hiding this comment.
To ensure consistency across the workspace and prevent potential version mismatch issues, pin vite-plus to the exact commit hash (d0b407c85b560c2470395176c9f1c838b5ca8af8) rather than the PR number (1703), matching the overrides defined in the root package.json.
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1703", | |
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@d0b407c85b560c2470395176c9f1c838b5ca8af8", |
fengmk2
changed the title
1 participant
Summary
Bump
vite-plusand related packages to the pkg-pr-new prerelease build for upstream PR voidzero-dev/vite-plus#1703 (commit d0b407c).Updated where applicable:
vite-plus,vitestalias,vitealias,@voidzero-dev/*overrides/resolutions/pnpm.overrides/ catalogsminimumReleaseAgeconfigTest plan