chore(deps): bump vite-plus to 0.1.21-alpha.7#4
Draft
fengmk2 wants to merge 2 commits into
Draft
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the vite-plus dependency to version 0.1.21-alpha.7 in both the root and playground package.json files. Feedback highlights that the changes are incomplete relative to the PR description, missing expected updates to vite, vitest, and the overrides block. Furthermore, the reviewer identified a version mismatch for vite across the workspace and a conflict between the mentioned package manager and the project configuration.
| "typescript": "^6.0.3", | ||
| "vite": "^8.0.10", | ||
| "vite-plus": "^0.1.19", | ||
| "vite-plus": "0.1.21-alpha.7", |
There was a problem hiding this comment.
The PR summary mentions updating vite, vitest, and overrides, but these changes are not reflected in this file.
- Dependencies:
vite(line 60) andvitest(line 62) remain unchanged. They should likely be updated and pinned to match thevite-plusalpha release to ensure compatibility. - Overrides: The
overridesblock is missing. This is required ifviteandvitestare intended to be aliases for@voidzero-devpackages as described. - Consistency: The summary refers to
pnpmconfigurations, but the project is configured to usenpm(line 65).
| "typescript": "^6.0.3", | ||
| "vite": "^8.0.3", | ||
| "vite-plus": "^0.1.19", | ||
| "vite-plus": "0.1.21-alpha.7", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
vite-plusand related packages to alpha 0.1.21-alpha.7.Updated where applicable:
vite-plusvitest(alias to@voidzero-dev/vite-plus-test)vite(alias to@voidzero-dev/vite-plus-core)overrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsminimumReleaseAgeExclude/minimumReleaseAgeExcludesconfigured for pnpm + bunTest plan