feat(deps): upgrade vite-plus to 0.1.15-alpha.7#2
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces parallel podcast synchronization, expands the dashboard overview with new sections like 'Hidden Gems' and 'Similar Songs,' and refactors various components for better consistency and error handling. It also upgrades several backend and frontend dependencies and establishes project guidelines in AGENTS.md. Feedback focuses on architectural violations regarding direct model queries, performance optimizations in the overview controller, and the use of magic numbers in the parallel sync service.
|
|
||
| public function handle(): int | ||
| { | ||
| $podcasts = Podcast::query()->whereIn('id', $this->argument('ids'))->get(); |
There was a problem hiding this comment.
This direct model query violates the rule in AGENTS.md stating that all model lookups and queries must go through the appropriate repository class. Please use a PodcastRepository instead.
|
|
||
| public function handle(): int | ||
| { | ||
| $ids = Podcast::query()->pluck('id')->all(); |
There was a problem hiding this comment.
According to the newly added guidelines in AGENTS.md, models should not be queried directly outside of their corresponding repository classes. Please use a PodcastRepository to fetch the IDs.
|
|
||
| private function syncSequentially(): int | ||
| { | ||
| Podcast::query()->get()->each(function (Podcast $podcast): void { |
There was a problem hiding this comment.
This direct model query violates the rule in AGENTS.md. Please use PodcastRepository to fetch the podcasts for sequential syncing.
| 'recently_added_albums' => AlbumResource::collection($albumRepository->getRecentlyAdded()), | ||
| 'recently_added_songs' => SongResource::collection($songRepository->getRecentlyAdded()), | ||
| 'recently_played_songs' => SongResource::collection($songRepository->getRecentlyPlayed()), | ||
| 'recently_added_artists' => ArtistResource::collection($artistRepository->getRecentlyAdded()), |
There was a problem hiding this comment.
For consistency with other sections and to ensure optimal performance, please consider adding a limit (e.g., 6) to the getRecentlyAdded() calls for albums and artists.
'recently_added_albums' => AlbumResource::collection($albumRepository->getRecentlyAdded(6)),
'recently_added_artists' => ArtistResource::collection($artistRepository->getRecentlyAdded(6)),| } | ||
|
|
||
| $process = new Process($command, base_path()); | ||
| $process->setTimeout(300); |
There was a problem hiding this comment.
The timeout value 300 is a magic number. It should be defined as a constant or made configurable to improve maintainability.
1 participant
Upgrade vite-plus and related packages to 0.1.15-alpha.7