Skip to content

chore(deps): bump vite-plus to pkg-pr-new PR #1703#3

Draft
fengmk2 wants to merge 3 commits into
masterfrom
update-vite-plus-prerelease-test-pr-1703
Draft

chore(deps): bump vite-plus to pkg-pr-new PR #1703#3
fengmk2 wants to merge 3 commits into
masterfrom
update-vite-plus-prerelease-test-pr-1703

Conversation

@fengmk2

@fengmk2 fengmk2 commented May 28, 2026

Copy link
Copy Markdown
Owner

Summary

Bump vite-plus and related packages to the pkg-pr-new prerelease build for upstream PR voidzero-dev/vite-plus#1703 (commit d0b407c).

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates pnpm-workspace.yaml to use preview builds from pkg.pr.new for vite, vitest, and vite-plus in both the catalog and overrides, alongside configuring release age settings. A review comment highlights a version mismatch between the catalog entries (using tag @1703) and the overrides (using a specific commit hash), which could lead to inconsistent dependency resolution, and suggests aligning them to use the same commit hash.

Comment thread pnpm-workspace.yaml
Comment on lines +5 to +7
vite: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1703
vitest: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1703
vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@1703

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There is a mismatch between the versions specified in the catalog and the overrides. The catalog entries use the PR-specific tag @1703, while the overrides use the specific commit hash @d0b407c85b560c2470395176c9f1c838b5ca8af8.

Since vite is an alias for @voidzero-dev/vite-plus-core (and vitest for @voidzero-dev/vite-plus-test), this mismatch can lead to inconsistent dependency resolution or duplicate package installations where some parts of the dependency tree resolve to the PR-level mutable build and others resolve to the pinned commit build.

To ensure consistency and reproducible builds, the catalog entries should be updated to use the same commit hash as the overrides.

  vite: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@d0b407c85b560c2470395176c9f1c838b5ca8af8
  vitest: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@d0b407c85b560c2470395176c9f1c838b5ca8af8
  vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@d0b407c85b560c2470395176c9f1c838b5ca8af8

@fengmk2 fengmk2 changed the title chore(deps): bump vite-plus to pkg-pr-new PR #1703 (d0b407c) chore(deps): bump vite-plus to pkg-pr-new PR #1703 May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant