Skip to content

feat: safely shut down target disk simulators before eject - #1

Merged
fengfe1125 merged 1 commit into
mainfrom
codex/simulator-safe-eject-20260924
Sep 24, 2026
Merged

fengfe1125 merged 1 commit into
mainfrom
codex/simulator-safe-eject-20260924

Conversation

@fengfe1125

Copy link
Copy Markdown
Owner

Summary

  • Eject preflight now inspects Apple simulator devices and verifies whether their data or runtime is stored on the target disk or a related mounted image.
  • After confirmation, it requests normal shutdown for each related running device and waits for an explicit shutdown state before detaching images or ejecting the disk.
  • Unknown inventory or scope, shutdown errors/timeouts, target changes, and newly started devices stop the flow. System-only and force-eject paths cannot bypass the simulator check.
  • Added bilingual progress/failure copy, demo fixtures, flow tests, and documentation.

Verification

  • swift test --disable-sandbox --scratch-path /private/tmp/devdisk-swift-build — 222 passed, 3 optional skips.
  • git diff --check passed; demo UI snapshot and debug app self-test passed.
  • No real disk eject was attempted.

Environment limits

  • CoreSimulatorService was unavailable, so live simulator shutdown integration could not be run. The WidgetRenderer_Default crash report showed a SIGTRAP in Apple SimulatorTrampoline/libdispatch; a causal link to DevDisk has not been established.
  • Release dSYM generation stopped with Operation not permitted; release packaging and installation were not verified.

Copilot AI lite review requested due to automatic review settings September 24, 2026 02:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@fengfe1125
fengfe1125 merged commit b9be6d0 into main Sep 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants