test: add cache-hit path tests for client/modules/search.ts - #2328
Merged
Conversation
Wire fake-indexeddb/auto in setupTests.ts so Dexie-based cache tests exercise the real IndexedDB code paths instead of silently erroring into catch blocks. Add 7 tests covering the cache-hit path previously uncovered: - Repeated text/image queries served from cache without second fetch - Different queries and limits produce separate cache entries - TTL expiry forces refetch - Caching disabled skips the cache - Text and image stores are independent
client/modules/search.ts
felladrin
marked this pull request as ready for review
August 10, 2026 21:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from #2130.
We test
performSearch, but nothing asserts that a repeated query is served from the IndexedDB cache and skips the network fetch — that's the module's headline feature and it's currently uncovered.What changed
fake-indexeddb/autoso Dexie-based cache tests exercise the real IndexedDB code paths instead of silently erroring into catch blocks.fake-indexeddbto devDependencies.Tests added
searchTextcall skipsfetch; log entry andtextHitscounter confirm the cache-hit branch.searchImageswithimageHitscounter.limitvalues produce separate cache keys.updateCacheConfig({ ttl: 0 })between calls triggers a second fetch.enabled: falsemakes both calls hit the network.searchTextandsearchImagesproduces 2 fetches; a third call to the image store hits the cache.Verification