Hold back npm packages published in the last three days - #2314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
min-release-age = 3to.npmrc, sonpm installwill not resolve a package version that went public less than three days ago. Most compromised releases are caught within hours of publication, so a short delay filters that class out before it ever reaches the lockfile.This complements Renovate rather than replacing it. Renovate's window applies to the version it proposes in a PR; this one also covers the transitive packages the resolver pulls in underneath, and it applies the same rule on my machine and inside Docker builds.
npm ciis deliberately unaffected: it installs exactly whatpackage-lock.jsonpins and skips the filter. Every install path in this repo isnpm ci(.github/workflows/ci.yml,.github/workflows/reusable-check-docker.ymland theDockerfile), so CI and image builds behave exactly as before.How to test
npm ci. It completes as usual, because the window does not apply to lockfile installs.npm install <package>@latestfor something published in the last day or two. npm resolves an older version, or errors withETARGETwhen no older version exists.min-release-age-exclude.