Skip to content

Add remaining navdata options#30

Merged
jfsiii merged 29 commits into
felixge:masterfrom
jfsiii:feature-new-navdata
Nov 21, 2012
Merged

Add remaining navdata options#30
jfsiii merged 29 commits into
felixge:masterfrom
jfsiii:feature-new-navdata

Conversation

@jfsiii
Copy link
Copy Markdown
Collaborator

@jfsiii jfsiii commented Nov 20, 2012

Added the 22 missing navdata options.

  • All the original tests pass.
  • Altered the demo and rawMeasures data structures.
  • Added tests for the all new values.
  • Eliminated as many French variables as I could, but many remain. It's especially hard to translate the abbreviations. For example, is Planif short for the French planification, which would be planned in English?
  • Added some guesses about units for the various properties (see 4ea2a51)

closes #29

John Schulz added 29 commits November 11, 2012 14:50
Unsure `ARDrone_SDK_2_0/ARDroneLib/Soft/Common/navdata_common.h:753` has `uint32_t link_quality` but using that:

 * Breaks a test
 * Produces a value from 0 - 500
 * Causes strange behavior[^1]

[^1]: (Values were observed to start at 500 and gradually decline to 0 in about 10 seconds. Sometime later the value would incrementally increase back to 500 and, again, slide back down to 0.)
Based on (guessing, after reading) ARDrone_SDK_2_0/ARDroneLib/Soft/Lib/ardrone_tool/Navdata/ardrone_navdata_file.c:51
@jfsiii
Copy link
Copy Markdown
Collaborator Author

jfsiii commented Nov 20, 2012

All done, @felixge. The only thing preventing me from merging is making sure you don't have any problems with:

jfsiii added a commit that referenced this pull request Nov 21, 2012
@jfsiii jfsiii merged commit 7277573 into felixge:master Nov 21, 2012
@felixge
Copy link
Copy Markdown
Owner

felixge commented Nov 22, 2012

Sorry for the delay.

the style of my tests (e.g. jfsiii/node-ar-drone@9c16838#L0R696)

No, those look great!

my approach to maintaining BC (support old and new keys, e.g jfsiii/node-ar-drone@5319cfc )

Well, we should figure out a normalized format going forward, as this may confuse people even more (are these the same values? or different ones?).

That being said, it's ok for now!

❤️ ! Thank you for all the work!

@jfsiii jfsiii deleted the feature-new-navdata branch May 22, 2013 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants