Skip to content

Better chaining API + object for config#28

Open
yocontra wants to merge 2 commits into
felixge:masterfrom
yocontra:master
Open

Better chaining API + object for config#28
yocontra wants to merge 2 commits into
felixge:masterfrom
yocontra:master

Conversation

@yocontra
Copy link
Copy Markdown
Collaborator

This allows you to do drone.up(0.5).front(1).clockwise(0.2) and also adds some sugar for setting multiple config options at once

drone.config({
  "someoption":"someval",
  "otheroption":"otherval"
});

This makes it easier to have your own drone config file and load it into the drone before you fly it.

Sidenote: is there any way currently to get the config from the drone?

@felixge
Copy link
Copy Markdown
Owner

felixge commented Nov 14, 2012

So I'm working on a new API for this whole thing, which is here: https://github.com/felixge/node-ar-drone/commits/new-api . Meanwhile I'm happy with any new patches coming in, in fact I just made you a contributor on the repo. What's your npm user name?

Anyway, returning this is problematic for users of the REPL. So you should change this patch so the REPL still stays usable and doesn't flood the screen.

Sidenote: is there any way currently to get the config from the drone?

No, not yet.

@yocontra
Copy link
Copy Markdown
Collaborator Author

@felixge -

Is there a way I can tell if the user is on the REPL to change the return values?

Do you have any docs on what you want the new API to look like so I can pitch in?

npm name is fractal

@felixge
Copy link
Copy Markdown
Owner

felixge commented Nov 18, 2012

@contra I've added you on npm. I'm not sure about detecting if you're inside a REPL, but there is probably a way : ).

There are no docs for the new API yet, but that's the next thing I'll work on so we can discuss them!

jfsiii pushed a commit to jfsiii/node-ar-drone that referenced this pull request Nov 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants