fix(ci): generate lockfile before security audit - #36
Merged
Conversation
rustsec/audit-check v2 no longer generates Cargo.lock. Create an ephemeral lockfile for the library audit and ignore advisories that only enter through dev dependencies pinned for backward-compatibility and integration tests.
febyeji
force-pushed
the
fix/security-audit-lockfile
branch
from
July 27, 2026 03:31
879c0d6 to
e2a9b07
Compare
febyeji
marked this pull request as ready for review
July 27, 2026 03:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cargo.lockbefore runningrustsec/audit-check@v2.rustls-webpkiadvisories that enter the lockfile only through dev dependencies pinned for backward-compatibility and integration tests.Root cause
rustsec/audit-check@v2no longer runscargo generate-lockfile, unlike v1.4.1. Sinceldk-nodeis a library and intentionally ignoresCargo.lock, the scheduled audit failed before it could inspect any dependencies.Generating the lockfile exposed three advisories for
rustls-webpki 0.101.7. That version is only pulled in byldk-node 0.6.2andelectrsd 0.36.1, which are dev dependencies retained for compatibility and integration testing.Impact
Scheduled and manually dispatched security audits can inspect the resolved dependency graph again without committing a library lockfile. Runtime dependencies remain fully audited; only the three documented dev-only advisories are excluded.
Validation
cargo generate-lockfilecargo metadata --locked --no-deps --format-version 1cargo-audit 0.22.2with the configured ignores: 0 vulnerabilities