Add lookahead to cbf chain source - #17
Closed
randomlogin wants to merge 0 commit into
Closed
Conversation
randomlogin
marked this pull request as draft
May 5, 2026 02:41
febyeji
approved these changes
May 6, 2026
febyeji
marked this pull request as ready for review
May 6, 2026 10:06
febyeji
marked this pull request as draft
May 6, 2026 10:06
febyeji
self-requested a review
May 6, 2026 10:07
randomlogin
marked this pull request as ready for review
May 7, 2026 14:36
febyeji
force-pushed
the
add-cbf-chain-source
branch
from
May 12, 2026 11:47
43d908f to
d1030d8
Compare
febyeji
approved these changes
May 12, 2026
febyeji
left a comment
febyeji
left a comment
Owner
There was a problem hiding this comment.
LGTM. I will merge this after it is rebased.
randomlogin
force-pushed
the
fix-cbf-bdk-spk-lookahead
branch
from
May 12, 2026 18:16
556545b to
cb1d1e9
Compare
randomlogin
force-pushed
the
fix-cbf-bdk-spk-lookahead
branch
from
May 12, 2026 18:22
cb1d1e9 to
d1030d8
Compare
Collaborator
Author
|
This change was already absorbed by another PR, sorry for miscommunication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BDK's reveal cursor won't advance based on matched scripts, so after wallet-funded activity the next register_or_subscribe_pending_sync will keep re-sending the same SPK set and may not reveal the next external/internal index.
Changed to be in style of https://github.com/bitcoindevkit/bdk-kyoto