fix(audio): correct sample limit tracking and source leaks#182
Open
fbraz3 wants to merge 1 commit into
Open
Conversation
Fixed a bug in OpenALAudioManager and MiniAudioManager where the engines would continuously allocate new hardware sources without terminating lower priority sounds, eventually exhausting all available physical sources. Also corrected the sample count logic in MiniAudioManager to only evaluate 2D and 3D sample types rather than all playing sounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where Voiceovers (like "You are victorious" or General Challenge taunts) were not playing, especially during late-game or heavy combat scenarios.
Changes
event->setHandleToKillinisPlayingLowerPriority()for both audio managers. Previously, when the maximum sample limits were hit (e.g., 64 2D sounds), the engines continuously generated new hardware sources without freeing older lower-priority ones. This eventually exhausted all physical sources (usually 256) and silently dropped new sounds.MiniAudioManager::getNumAvailable2DSamplesandgetNumAvailable3DSamplesto calculate available samples by only countingPAT_SampleandPAT_3DSamplerespectively. Previously, it counted the entirem_playingSoundslist (which includes Music/Streams), keeping available samples at 0 and triggering continuous lower-priority replacements.