chore(network): disable retail compatibility, move legacy submodules, and update docs#181
Merged
Conversation
… and update docs - Disables RETAIL_COMPATIBLE_NETWORKING in GameDefines.h. - Fixes compiler error in GameLogic.cpp CRC mismatch logging. - Moves fighter19-dxvk-port, jmarshall-win64-modern, and thesuperhackers-main to references/old-refs/. - Updates documentation cross-references to the moved submodules. - Adds .codegraphignore for references. - Adds RETAIL_COMPATIBILITY.md audit report.
…tiplier Initialize m_timeMultiplier to 1 in the W3DView constructor to prevent garbage memory from disabling FPS limits. Also fix the FrameRateLimit fast-path check to correctly identify UncappedFpsValue (1,000,000) as uncapped by changing the condition from > 1000000 to >= 1000000.
…nerals Backport LAN lobby configured IP preference honoring and diagnostics from Zero Hour (GeneralsMD). Also backport CRC mismatch and timeout diagnostic logging to stderr to help diagnose network synchronization failures in Generals base game.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request brings multiple network stability, security, and cleanup changes to resolve LAN matchmaking and connectivity issues under macOS and Linux.
Details & Context
std::vectorandstd::accumulate), so we successfully avoided unnecessary downgrades.RETAIL_COMPATIBLE_NETWORKINGby default inGameDefines.h, which removes legacy packet size limitations (increasing max UDP payload to 1100 bytes) and resolves command ID overflow disconnect bugs in long matches. An audit report of all such compatibility macros has been added todocs/WORKDIR/audit/RETAIL_COMPATIBILITY.md.fighter19-dxvk-port,jmarshall-win64-modern, andthesuperhackers-main) intoreferences/old-refs/to clean up the rootreferences/directory. All documentation cross-references have been updated to reflect their new locations.references/.codegraphignoreto prevent code indexing tools from being bogged down by reference submodules.Changes
Core/GameEngine/Include/Common/GameDefines.h: DisableRETAIL_COMPATIBLE_NETWORKING.GeneralsMD/Code/GameEngine/Source/GameLogic/System/GameLogic.cpp: Fix CRC mismatch parameters..gitmodules: Move legacy reference submodules.references/old-refs/: Location of historical reference submodules.docs/WORKDIR/audit/RETAIL_COMPATIBILITY.md: Created macro audit documentation.