SagePatch: pin target to C++17 so macOS builds#180
Merged
Conversation
The sage_patch sources use modern C++ (scoped enums, brace-init), but the target sets no C++ standard and inherits the engine's global C++98. With a standards-strict compiler (AppleClang) this fails: error: scoped enumerations are a C++11 extension Pin sage_patch to CXX_STANDARD 17 so it builds on macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Building
sage_patchon macOS fails with:The
sage_patchsources use modern C++ (scoped enums, brace-init), but the target sets no C++ standard, so it inherits the engine's global C++98. A standards-strict compiler (AppleClang) then rejects the C++11/17 constructs and the macOS build breaks.Fix
Pin the
sage_patchtarget to C++17 (independent of the legacy engine's standard):One-line behavior change, scoped to the
sage_patchtarget only. Verified: the macOSz_generalsbuild links cleanly with this in place.🤖 Generated with Claude Code