Repository navigation
fix(inspector): discover context menus and submenus in element searches - #25
Open
gaoshang212 wants to merge 1 commit into
Open
gaoshang212 wants to merge 1 commit into
gaoshang212 wants to merge 1 commit into
Conversation
1. Include presentation roots on the Inspector UI thread so searches can discover open context menus and expanded submenus. 2. Deduplicate overlapping subtrees before applying result limits while preserving explicit root scope. 3. Add popup search regression tests and document the search behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Element searches can now discover open context menus and expanded submenus that live outside application window trees.
Explicit
root_handlesearches retain their subtree scope. Add regression coverage and document the behavior.Evidence
GetAllSearchRootsonly enumeratedApplication.Windows, excluding independent context-menu presentation roots. Each window search accumulated results separately.The test build also compiled the Inspector for
net472,net48, andnet8.0-windows; runtime tests ran on .NET 8.git diff --checkpassed.Merge Danger
Door: two-way
Revert the commit to restore the previous search behavior; no data migration or public IPC contract changes.
Blast Radius: Inspector
Unscoped consumers of shared search roots, including element lookup, waits, diagnostics, and workflow selectors, can now see independent presentation roots on the Inspector UI thread. Explicitly scoped searches remain limited to their subtree.