Repository navigation
feat(inspector): show inspection and recording window outlines - #24
Open
gaoshang212 wants to merge 1 commit into
Open
gaoshang212 wants to merge 1 commit into
gaoshang212 wants to merge 1 commit into
Conversation
1. Show a non-interactive red outline while Inspector runs and switch it to orange during recording. 2. Exclude Inspector outlines from visual tree traversal and remove them when Inspector stops. 3. Document the outline lifecycle and add rendering and recording tests. Validation: 17 targeted tests passed; verified worker-thread startup, UI dispatch, recording color changes, and shutdown cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a visible window outline to identify the inspected application and make active recordings easy to recognize. Without a clear recording indicator, users may unintentionally interact with the application or move the mouse/type during physical automation, changing application state and affecting recording results.
The outline is non-interactive, follows window layout changes, and is excluded from Inspector visual tree traversal. It provides an at-a-glance reminder to avoid unintended input while recording or running physical automation.
Evidence
After: Red and orange outlines make inspection and recording states visible directly on the application window.
Merge Danger
Door: Two-way. The feature can be reverted without changing recording formats or the IPC protocol.
Blast Radius: Inspector.
Applies to injected and self-hosted WPF windows on the Inspector UI Dispatcher that provide an adorner layer. The outline follows the Inspector lifecycle: it remains after a client detaches and is removed when Inspector stops. Native title bars are outside the WPF outline.