Skip to content

feat(inspector): show inspection and recording window outlines - #24

Open
gaoshang212 wants to merge 1 commit into
faze79:mainfrom
gaoshang212:feature/attachment-recording-border
Open

gaoshang212 wants to merge 1 commit into
faze79:mainfrom
gaoshang212:feature/attachment-recording-border

Conversation

@gaoshang212

Copy link
Copy Markdown

Summary

Add a visible window outline to identify the inspected application and make active recordings easy to recognize. Without a clear recording indicator, users may unintentionally interact with the application or move the mouse/type during physical automation, changing application state and affecting recording results.

Inspector starts       -> Red outline: inspection active
Recording starts       -> Orange outline: recording active
Recording stops/clears -> Red outline
Inspector stops        -> Outline removed

The outline is non-interactive, follows window layout changes, and is excluded from Inspector visual tree traversal. It provides an at-a-glance reminder to avoid unintended input while recording or running physical automation.

Evidence

  • Before: No persistent window outline distinguished inspection from active recording.
    After: Red and orange outlines make inspection and recording states visible directly on the application window.
  • Automated: 17 targeted tests passed: 11 outline/recorder integration tests and 6 process-manager tests. Coverage includes border rendering, input transparency, layout/template changes, color transitions, and cleanup.
  • Manual: Verified initialization from a worker thread, dispatch to the WPF UI thread, red -> orange -> red transitions, and outline removal when Inspector stops.

Merge Danger

Door: Two-way. The feature can be reverted without changing recording formats or the IPC protocol.

Blast Radius: Inspector.

Applies to injected and self-hosted WPF windows on the Inspector UI Dispatcher that provide an adorner layer. The outline follows the Inspector lifecycle: it remains after a client detaches and is removed when Inspector stops. Native title bars are outside the WPF outline.

1. Show a non-interactive red outline while Inspector runs and switch
   it to orange during recording.
2. Exclude Inspector outlines from visual tree traversal and remove
   them when Inspector stops.
3. Document the outline lifecycle and add rendering and recording tests.

Validation: 17 targeted tests passed; verified worker-thread startup,
UI dispatch, recording color changes, and shutdown cleanup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant