feat(gui): add timestamp checkbox to output filename - #13
Conversation
- Add checkbox next to output filename entry to include YYYYMMDD_HHMMSS timestamp in default filename - Update default_name() to support timestamp injection with collision suffix handling (_1, _2, etc.) - Enhance should_update_default() with regex pattern matching to recognize timestamped defaults without recomputing the exact string - Add _suppress_changed guard to distinguish programmatic vs user edits and prevent false 'user modified' flags during live updates - Extract output filename from built command in _execute() to prevent notification showing wrong name after file exists on disk - Add deterministic tests with frozen clock to prevent CI flakiness - Preserve backward compatibility by appending include_timestamp param to end of default_name() signature
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds timestamp-aware default filenames to the GUI, recognizes generated filename variants, wires timestamp selection through GTK4 and command construction, and reports the actual executed output filename. Tests cover timestamp generation, collisions, default detection, and command output. ChangesTimestamped output defaults
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant GTK4_UI
participant build_command
participant CLI
participant SuccessNotification
GTK4_UI->>build_command: pass timestamp and output options
build_command->>CLI: construct command with -o output path
CLI-->>SuccessNotification: return executed command
SuccessNotification->>SuccessNotification: extract actual output filename
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
New Features
Bug Fixes