IIRR-32: Add feature to filter the archived list by low success rate#76
Merged
Conversation
arielj
commented
May 18, 2026
| explanation: "This is a test puzzle" | ||
| link: "https://example.com" | ||
| state: "approved" | ||
| sent_at: <%= 1.day.ago %> |
Contributor
Author
There was a problem hiding this comment.
approved puzzles shouldn't have a sent_at value, they are not sent yet
JuanVqz
approved these changes
May 18, 2026
Member
JuanVqz
left a comment
JuanVqz
left a comment
There was a problem hiding this comment.
It is working; left some comments, but they are optional, we can fix them later if needed.
| end | ||
|
|
||
| def self.only_low_success_rate | ||
| includes(:answers).to_a.select { |ans| ans.correct_answer_percentage <= 80 } |
Member
There was a problem hiding this comment.
I propose changing from ans to p because is a puzzle sending correct_answer_percentage not answer.
Suggested change
| includes(:answers).to_a.select { |ans| ans.correct_answer_percentage <= 80 } | |
| includes(:answers).to_a.select { |p| p.correct_answer_percentage <= 80 } |
And one question: Is this equivalent to a scope or should we use the scope syntax here?
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new filter for the Archived table to only show puzzles with a success answer rate lower than or equal to 80%.
I also updated the
correct_answer_percentageto reuse the already loaded association when possible to avoid extra DB queries.