Allow scaleFromZero with a custom Envoy configuration - #90
Merged
Merged
Conversation
The chart no longer refuses scaleFromZero.enabled together with envoy.external_config.load_from_configmap. A custom configuration is responsible for the clusters, Lua filter and routes that the generated one would have added. The Lua ConfigMap is now created for external configs as well; the Envoy Deployment mounts it whenever the filter is enabled, so without it the pod could not start. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The Prometheus Operator install floats on whatever prometheus-community/kube-prometheus-stack is latest. 90.0.0, published between 2026-09-05 and 2026-09-07, made the control-plane ServiceMonitors authenticate via a Secret that is only rendered when prometheus.enabled and prometheus.serviceAccount.create are both true. These call sites pass prometheus.enabled=false -- they want the operator and its CRDs, nothing else -- so templating now fails: The control-plane ServiceMonitors authenticate by default with the Secret created by prometheus.serviceAccount.createTokenSecret, which is only rendered when prometheus.enabled and prometheus.serviceAccount.create are also true. Bisected: 89.2.4 and every earlier release template fine with these flags; 90.0.0 is the first that does not. Pinning 89.2.4 keeps CI reproducible and matches how the chart's own dependencies are pinned. 89.2.4 still ships the servicemonitors CRD and the operator Deployment, which is all these steps need. The alternative -- tracking latest and disabling every control-plane exporter (kubelet, kubeApiServer, kubeControllerManager, kubeScheduler, kubeProxy, kubeEtcd, coreDns) -- also works on 90.0.0 but adds seven flags to each call site and would not protect against the next upstream change. This break is independent of this branch: it fails identically on main, which has not run CI since 90.0.0 was published. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 444bdc3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #85:
scaleFromZero.enabledno longer refuses to render together withenvoy.external_config.load_from_configmap. A custom configuration is responsible for the clusters, Lua filter and routes that the generated one would have added; the chart does not check for them.The Lua ConfigMap is now created for external configs as well, since the Envoy Deployment mounts it whenever the filter is enabled.
🤖 Generated with Claude Code