ensure tracked receiver not subject to i/o budget#48378
Merged
Conversation
clintjedwards
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connection tasks are expected to consume all ZHTTP messages waiting for them when they are next polled. However, if a task exhausts its I/O budget then it may return from its poll method without having consumed all the messages. This PR makes reads from
TrackedAsyncLocalReceiver(the type used exclusively for reading these messages) exempt from the I/O budget so that the tasks can meet their obligations no matter what.Allowing unlimited reads here is not as scary as it sounds. The channel has a queue size of 1, and the sending task yields while the receiving task is polled, meaning there should only ever be 1 message for the receiving task to read. This change should not result in tasks doing unfair numbers of reads.