add ffi around rust url crate, with implicit sharing#48377
Open
jkarneges wants to merge 1 commit into
Open
Conversation
jkarneges
force-pushed
the
jkarneges/url-ffi
branch
from
2f2280c to
4a564cd
Compare
jkarneges
force-pushed
the
jkarneges/url-ffi
branch
from
4a564cd to
48c6bd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an FFI around the
urlcrate, as the basis for aQUrlreplacement.Notably,
QUrlis an implicitly shared type. To support similar behavior here, the data is wrapped inArc, andArc::make_mutis used for copy-on-write operations.There is also one limitation: the Rust
Urltype does not support relative URLs, whereasQUrldoes. Since there are only a few places in the C++ code where we need relative URLs, and those URLs are always resolved against an absolute base URL before being used for anything, my plan is for the C++ code to simply store relative URLs in string types.