add urlquery as a wrapper around qurlquery#48375
Merged
Merged
Conversation
jkarneges
force-pushed
the
jkarneges/urlquery-wrapper
branch
from
649b029 to
17a619d
Compare
jkarneges
force-pushed
the
jkarneges/urlquery-wrapper
branch
from
17a619d to
4ace537
Compare
clintjedwards
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of migrating away from
QUrl, this PR adds a wrapper to help with migrating away from a companion type,QUrlQuery.Unlike
Urlwhich is currently an alias forQUrluntil it is replaced with a substitute implementation, forUrlQueryI've gone straight to a wrapper. This way we have more control over it at the time theUrlimplementation is substituted. Notably, we'll be able to maintain aUrlQuery(const Url &)constructor through that transition, which would not be possible ifUrlQuerywere simply an alias forQUrlQuery.After this lands, the plan is to replace the implementation of
Urlwith one based on the Rusturlcrate. TheUrlQuerytype can remain Qt-backed through that transition, and later we can figure out how to substitute its implementation as well.