Make thenable plugins have the right name on errors - #359
Open
segevfiner wants to merge 1 commit into
Open
Conversation
When an plugin registerd via an `import` without await timeouts you got the useless `[object Promise]` name in the error message. This PR fixes that by setting name of the plugin earlier so that it is used in the error message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an plugin registerd via an
importwithoutawait timeouts you got the useless
[object Promise]name in the error message. This PR fixesthat by setting name of the plugin earlier so that
it is used in the error message.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct