Repository navigation
Conversation
Lazy str proxies (e.g. Django gettext_lazy) passed as Argument help crashed non-rich --help because get_help_record returned a non-str. Apply inspect.cleandoc the same way TyperOption already does.
inspect.cleandoc uses expandtabs via __getattr__, so the stand-in __str__ was never executed and coverage-combine failed under 100%.
svlandeg
reviewed
Sep 29, 2026
svlandeg
left a comment
svlandeg
left a comment
Member
There was a problem hiding this comment.
Closing as violating the contribution guidelines - this has been discussed but not approved for a PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Discussion: #1953
Description
TyperOptionrunsinspect.cleandoc(help)in its constructor, which alsocoerces lazy str proxies (e.g. Django
gettext_lazy) to real strings.TyperArgumentdid not, so non-rich--helpcrashed with:TypeError: expected string or bytes-like objectwhen Argument help was a non-str proxy and no extra metadata forced an
f-string coercion.
This applies the same
cleandocstep toTyperArgument.Checklist