Skip to content

Commit 4977287

Browse files
committed
Fix Session context manager mocking in pre-start tests
1 parent 4ac6c0c commit 4977287

2 files changed

Lines changed: 12 additions & 26 deletions

File tree

backend/tests/scripts/test_backend_pre_start.py

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,23 +8,16 @@
88
def test_init_successful_connection() -> None:
99
engine_mock = MagicMock()
1010

11-
session_mock = MagicMock()
12-
session_mock.exec.return_value = True
11+
session_cm = MagicMock()
12+
session = session_cm.__enter__.return_value
13+
session.exec.return_value = True
1314

1415
with (
15-
patch("sqlmodel.Session", return_value=session_mock),
16+
patch("sqlmodel.Session", return_value=session_cm),
1617
patch.object(logger, "info"),
1718
patch.object(logger, "error"),
1819
patch.object(logger, "warn"),
1920
):
20-
try:
21-
init(engine_mock)
22-
connection_successful = True
23-
except Exception:
24-
connection_successful = False
21+
init(engine_mock)
2522

26-
assert connection_successful, (
27-
"The database connection should be successful and not raise an exception."
28-
)
29-
30-
session_mock.exec.assert_called_once_with(select(1))
23+
session.exec.assert_called_once_with(select(1))

backend/tests/scripts/test_test_pre_start.py

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,23 +8,16 @@
88
def test_init_successful_connection() -> None:
99
engine_mock = MagicMock()
1010

11-
session_mock = MagicMock()
12-
session_mock.exec.return_value = True
11+
session_cm = MagicMock()
12+
session = session_cm.__enter__.return_value
13+
session.exec.return_value = True
1314

1415
with (
15-
patch("sqlmodel.Session", return_value=session_mock),
16+
patch("sqlmodel.Session", return_value=session_cm),
1617
patch.object(logger, "info"),
1718
patch.object(logger, "error"),
1819
patch.object(logger, "warn"),
1920
):
20-
try:
21-
init(engine_mock)
22-
connection_successful = True
23-
except Exception:
24-
connection_successful = False
21+
init(engine_mock)
2522

26-
assert connection_successful, (
27-
"The database connection should be successful and not raise an exception."
28-
)
29-
30-
session_mock.exec.assert_called_once_with(select(1))
23+
session.exec.assert_called_once_with(select(1))

0 commit comments

Comments
 (0)