Skip to content

Commit 4ac6c0c

Browse files
committed
Fix MagicMock misuse in pre-start tests for Python 3.12+
1 parent ac9319d commit 4ac6c0c

2 files changed

Lines changed: 10 additions & 16 deletions

File tree

backend/tests/scripts/test_backend_pre_start.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ def test_init_successful_connection() -> None:
99
engine_mock = MagicMock()
1010

1111
session_mock = MagicMock()
12-
exec_mock = MagicMock(return_value=True)
13-
session_mock.configure_mock(**{"exec.return_value": exec_mock})
12+
session_mock.exec.return_value = True
1413

1514
with (
1615
patch("sqlmodel.Session", return_value=session_mock),
@@ -24,10 +23,8 @@ def test_init_successful_connection() -> None:
2423
except Exception:
2524
connection_successful = False
2625

27-
assert (
28-
connection_successful
29-
), "The database connection should be successful and not raise an exception."
26+
assert connection_successful, (
27+
"The database connection should be successful and not raise an exception."
28+
)
3029

31-
assert session_mock.exec.called_once_with(
32-
select(1)
33-
), "The session should execute a select statement once."
30+
session_mock.exec.assert_called_once_with(select(1))

backend/tests/scripts/test_test_pre_start.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ def test_init_successful_connection() -> None:
99
engine_mock = MagicMock()
1010

1111
session_mock = MagicMock()
12-
exec_mock = MagicMock(return_value=True)
13-
session_mock.configure_mock(**{"exec.return_value": exec_mock})
12+
session_mock.exec.return_value = True
1413

1514
with (
1615
patch("sqlmodel.Session", return_value=session_mock),
@@ -24,10 +23,8 @@ def test_init_successful_connection() -> None:
2423
except Exception:
2524
connection_successful = False
2625

27-
assert (
28-
connection_successful
29-
), "The database connection should be successful and not raise an exception."
26+
assert connection_successful, (
27+
"The database connection should be successful and not raise an exception."
28+
)
3029

31-
assert session_mock.exec.called_once_with(
32-
select(1)
33-
), "The session should execute a select statement once."
30+
session_mock.exec.assert_called_once_with(select(1))

0 commit comments

Comments
 (0)