Fix blank Settings window redirect#97
Open
khaledmhirsi wants to merge 2 commits into
Open
Conversation
The Settings scene used EmptyView() which left users with a blank window when pressing Cmd+,. Replace with a small view that explains the app lives in the menu bar. Fixes farzaa#12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The menu-bar-only app still exposes SwiftUI's Settings scene through Cmd+,. That scene was
EmptyView(), so users who opened Settings saw a blank window and assumed API-key configuration was missing.Validation
swiftc -parse leanring-buddy/*.swiftgit diff --check origin/main...HEADFixes #12. Supersedes/patches #20, since I could not push directly to the contributor fork.