Skip to content

Link the MSVC C runtime statically; release 0.0.4 - #91

Merged
faratech merged 5 commits into
mainfrom
static-crt
Oct 17, 2026
Merged

faratech merged 5 commits into
mainfrom
static-crt

Conversation

@faratech

@faratech faratech commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

Fixes #92
Fixes #93
Fixes #94

Release executables imported VCRUNTIME140.dll, which ships only with the VC++ Redistributable. On clean Windows installs, including the winget validation sandbox, the exe failed to start with STATUS_DLL_NOT_FOUND (0xC0000135).

This links the MSVC C runtime statically (+crt-static) for the Windows targets and bumps the patch version for a fixed release. Binary size grows by ~100-200 KB; no runtime dependency remains.

🤖 Generated with Claude Code

faratech and others added 3 commits October 17, 2026 02:49
Release executables imported VCRUNTIME140.dll, which ships only with the
VC++ Redistributable. On clean Windows installs (and the winget validation
sandbox) the exe failed to start with STATUS_DLL_NOT_FOUND (0xC0000135).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fixes #93

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@faratech

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T03:20:08.169799Z ee79171 Manual request
🔒 Security Review ✅ Completed 2026-10-17T03:21:51.801798Z ee79171 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cd68329cd1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread wftui/Cargo.toml Resolved
@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: cd68329cd1

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

faratech and others added 2 commits October 17, 2026 03:17
titles_and_hrefs_carry_no_control_characters asserted on bare OSC output
but read TMUX/STY/TERM from the live env, so it failed whenever cargo test
ran inside tmux (DCS passthrough) and raced sibling env mutations. A
with_mux_env helper sets the env under ENV_LOCK and restores it on drop.

Fixes #94

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@faratech

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: ee79171d2f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@faratech
faratech merged commit bdd4bc0 into main Oct 17, 2026
2 checks passed
@faratech
faratech deleted the static-crt branch October 17, 2026 03:21
@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: ee79171d2f

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant