Repository navigation
Conversation
The unit test job runs the suite one test at a time and takes about 13 minutes. On a branch with the open pull requests merged in, the suite is twice the size and the job hits its 20 minute timeout at three quarters of the run, with no test failing. The tests are written to be independent of each other and of their order, and the suite is already run with pytest-xdist locally. CI and `make init` now install pytest-xdist, pinned like pytest, and the job and `make test` run `pytest -n auto`, so `make test` still runs what CI runs. AGENTS.md says so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unit test job runs the suite one test at a time: about 13 minutes on master (the last runs on #347 took 12 to 13). On a branch with the open pull requests merged in, the suite is about 5,300 tests, and the Python 3.12 and 3.13 jobs on #344 hit the job's 20 minute timeout at three quarters of the run with no test failing. Once those PRs land, master's jobs would do the same.
Change. One commit, 4e9cf96.
.github/workflows/test.yml: the job also installspytest-xdist==3.8.0, pinned like pytest and pytest-cov, and runspython -m pytest -n auto.Makefile:make initinstalls the same, andmake testrunspytest -n auto, so it still runs exactly what CI runs.AGENTS.md: the three places that name the dev tools and the test command say so.The tests do not depend on each other or on their order: the suite is already run with xdist locally, and
-n 4is what every branch's full run in the recent PRs used.Measured. This branch,
python -m pytest -n autoon a 4-core machine: 2494 passed in 4:38, against about 13 minutes serially in CI.ruff check .is clean.Nothing else changes:
pytest.ini, the test files andtest-coverageare as they were.