Skip to content

Pin the partner logo to the navbar's corner, and say to look at the pages - #342

Open
r0ny123 wants to merge 2 commits into
masterfrom
test/pin-partner-logo
Open

r0ny123 wants to merge 2 commits into
masterfrom
test/pin-partner-logo

Conversation

@r0ny123

@r0ny123 r0ny123 commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

#253 turned .navbar .right-logo in navbar.css from an absolutely positioned corner logo into a flex item. From 992px up, the FKIE logo then sat beside the MCRIT logo instead of at the right edge. Every unit, browser and Lighthouse check passed, and it reached master, where 28ea8f5 fixed it. Nothing compared where the logo lands; this test does, and AGENTS.md now asks for the look that would have caught it.

Test (eae0146). tests/testNavbarLogosBrowser.py, Chromium, loads / signed out and signed in as a contributor (the logo shows in both):

  • At 992, 1280 and 1920px:
    • the logo is visible and 40px high;
    • its right edge is 1rem (±2px) from the navbar's right edge, and its top is 0 to 5px below the navbar's top (the CSS gives 3px);
    • elementFromPoint at its centre returns the logo, so nothing is drawn over it;
    • it is right of the MCRIT logo, and the toggler and every visible menu link or button stay left of its right edge and overlap it by at most 4px vertically (the menu links' padding reaches about 2.6px under the logo by design).
  • At 991 and 390px it is not displayed (d-lg-block).

AGENTS.md (8a60571). The Testing section gains a paragraph after "verify by exercising the app": before calling a change to a template, a stylesheet or a page script done, screenshot every page it can affect on the base and on the branch, at 390, 820, 1280 and 1920px and in both themes where there are two, and look at each pair. A change to base.html, navbar.css, style.css or a shared macro affects every page. Every visible difference is either the intended change, named in the PR description, or a regression to fix with a browser test that pins the element's position or size. A merge that resolves a template or stylesheet conflict counts as a change.

Evidence.

  • On master (8fd5a8c): the new test passes, 10 of 10.
  • With Establish UI/UX parity and design consistency across views #253's rule put back (display:flex; align-items:center; margin-left:1rem): the six 992/1280/1920 tests fail, e.g. "at 1280px the partner logo is 921px from the navbar's right edge, not 1rem; it is at x=216-359"; the 991 and 390 tests pass, as they should.
  • With the AGENTS.md change: the test modules that read AGENTS.md and the new test, 91 passed. tests/testUiParity.py, testBrowser.py, testIconPreload.py and testBootstrapDataAttributes.py with the test: 32 passed. ruff check . is clean.
  • Screenshots of the navbar at 1920 and 390px on this branch were looked at: the Fraunhofer logo is in the top-right corner above Login and the help icon at 1920; at 390 only the MCRIT logo and the menu button show.

The open PRs carrying #160's dark theme use themed_img() for the logo; once that lands, this test measures whichever image is shown.

#253 made the FKIE logo a flex item, which put it beside the MCRIT logo
from 992px up, and no test noticed. A browser test now measures the logo
signed out and signed in at 992, 1280 and 1920px (visible, 40px high, 1rem
from the right edge, in the top corner, nothing over it or overlapping the
menu) and checks it is hidden at 991 and 390px.
#253 moved the FKIE logo out of the navbar's top-right corner from 992px
up, and every test and Lighthouse check passed: none of them compares where
things land. The Testing section now asks for screenshots of the pages a
change can affect, before and after, at 390, 820, 1280 and 1920px and in
both themes, each pair looked at; a difference is either the intended
change, named in the PR, or a regression pinned by a browser test such as
testNavbarLogosBrowser.py. A merge that resolves a template or stylesheet
conflict counts as a change.
@r0ny123 r0ny123 changed the title Test that the partner logo sits in the navbar's top-right corner Pin the partner logo to the navbar's corner, and say to look at the pages Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant