Repository navigation
Conversation
#253 made the FKIE logo a flex item, which put it beside the MCRIT logo from 992px up, and no test noticed. A browser test now measures the logo signed out and signed in at 992, 1280 and 1920px (visible, 40px high, 1rem from the right edge, in the top corner, nothing over it or overlapping the menu) and checks it is hidden at 991 and 390px.
#253 moved the FKIE logo out of the navbar's top-right corner from 992px up, and every test and Lighthouse check passed: none of them compares where things land. The Testing section now asks for screenshots of the pages a change can affect, before and after, at 390, 820, 1280 and 1920px and in both themes, each pair looked at; a difference is either the intended change, named in the PR, or a regression pinned by a browser test such as testNavbarLogosBrowser.py. A merge that resolves a template or stylesheet conflict counts as a change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#253 turned
.navbar .right-logoinnavbar.cssfrom an absolutely positioned corner logo into a flex item. From 992px up, the FKIE logo then sat beside the MCRIT logo instead of at the right edge. Every unit, browser and Lighthouse check passed, and it reached master, where 28ea8f5 fixed it. Nothing compared where the logo lands; this test does, and AGENTS.md now asks for the look that would have caught it.Test (eae0146).
tests/testNavbarLogosBrowser.py, Chromium, loads/signed out and signed in as a contributor (the logo shows in both):elementFromPointat its centre returns the logo, so nothing is drawn over it;d-lg-block).AGENTS.md (8a60571). The Testing section gains a paragraph after "verify by exercising the app": before calling a change to a template, a stylesheet or a page script done, screenshot every page it can affect on the base and on the branch, at 390, 820, 1280 and 1920px and in both themes where there are two, and look at each pair. A change to
base.html,navbar.css,style.cssor a shared macro affects every page. Every visible difference is either the intended change, named in the PR description, or a regression to fix with a browser test that pins the element's position or size. A merge that resolves a template or stylesheet conflict counts as a change.Evidence.
display:flex; align-items:center; margin-left:1rem): the six 992/1280/1920 tests fail, e.g. "at 1280px the partner logo is 921px from the navbar's right edge, not 1rem; it is at x=216-359"; the 991 and 390 tests pass, as they should.tests/testUiParity.py,testBrowser.py,testIconPreload.pyandtestBootstrapDataAttributes.pywith the test: 32 passed.ruff check .is clean.The open PRs carrying #160's dark theme use
themed_img()for the logo; once that lands, this test measures whichever image is shown.