Repository navigation
Conversation
static/trace_CFG/lib/jquery-3.1.1.min.js came in with CFGExplorer but was never loaded. Its only references were script tags inside an HTML comment at the top of the style block, in templates/single_function.html:6-9 and templates/result_compare_function_vs.html:6-9. Nothing else in the repository names the file: not the other templates, the Python code, the tests, the docs or setup.py, and no script loads it at runtime (no getScript, importScripts or script element built in JS). The pages get jQuery 3.6.0 from static/jquery.js through base.html, and trace_CFG/main.js and main_duo.js use that global $. This deletes the file (85 KB) and the commented-out block, which also held a tag for trace_CFG/lib/split.js. split.js is left in place: it is referenced nowhere else either, but removing it was not part of this change. Checked with the full test suite and ruff check. The function page and the function comparison page were also rendered in the test client: they still load trace_CFG/lib/d3.min.js and no longer contain jquery-3.1.1.
This was referenced Oct 13, 2026
This was referenced Oct 20, 2026
danielplohmann
added a commit
that referenced
this pull request
Oct 24, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
static/trace_CFG/lib/jquery-3.1.1.min.js(85 KB) came in with CFGExplorer and no page loads it (#260). Its only references were script tags inside an HTML comment atsingle_function.html:6-9andresult_compare_function_vs.html:6-9. This deletes the file and that comment block.Why it's safe. Nothing else in the repository names the file: not the other templates, the Python code, the tests, the docs or
setup.py. No script loads it at runtime either; there's nogetScript,importScripts, or script element built in JS. The CFG pages get jQuery 3.6.0 fromstatic/jquery.jsthroughbase.html, andtrace_CFG/main.jsandmain_duo.jsuse that global$.What stays. The same comment block held a tag for
trace_CFG/lib/split.js. It's just as unused (itsSplit()calls inmain.jsandmain_duo.jsare commented out next to "MCRIT Split no longer needed"), but AGENTS.md asks to leave vendoredtrace_CFG/files alone, so it stays in place. It can go in a one-line follow-up if wanted.Verification.
trace_CFG/lib/d3.min.js, and no longer containjquery-3.1.1; live, both pages showed no console errors.ruff check .is clean;python -m pytestgives 1275 passed, 7 skipped.Relation to open PRs. #245 moves the CFG scripts lower in
result_compare_function_vs.html, right next to the deleted comment: drop the comment block and keep #245's moved tags.single_function.htmlmerges cleanly with it. Stacked on #263, with no dependency on it.Closes #260.