Skip to content

Remove the unused jQuery 3.1.1 copy from trace_CFG (#260) - #264

Closed
r0ny123 wants to merge 2 commits into
fix/secret-key-racefrom
fix/drop-jquery-3.1.1
Closed

r0ny123 wants to merge 2 commits into
fix/secret-key-racefrom
fix/drop-jquery-3.1.1

Conversation

@r0ny123

@r0ny123 r0ny123 commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator

static/trace_CFG/lib/jquery-3.1.1.min.js (85 KB) came in with CFGExplorer and no page loads it (#260). Its only references were script tags inside an HTML comment at single_function.html:6-9 and result_compare_function_vs.html:6-9. This deletes the file and that comment block.

Why it's safe. Nothing else in the repository names the file: not the other templates, the Python code, the tests, the docs or setup.py. No script loads it at runtime either; there's no getScript, importScripts, or script element built in JS. The CFG pages get jQuery 3.6.0 from static/jquery.js through base.html, and trace_CFG/main.js and main_duo.js use that global $.

What stays. The same comment block held a tag for trace_CFG/lib/split.js. It's just as unused (its Split() calls in main.js and main_duo.js are commented out next to "MCRIT Split no longer needed"), but AGENTS.md asks to leave vendored trace_CFG/ files alone, so it stays in place. It can go in a one-line follow-up if wanted.

Verification.

  • The function page and the function comparison page render in the test client, still load trace_CFG/lib/d3.min.js, and no longer contain jquery-3.1.1; live, both pages showed no console errors.
  • ruff check . is clean; python -m pytest gives 1275 passed, 7 skipped.

Relation to open PRs. #245 moves the CFG scripts lower in result_compare_function_vs.html, right next to the deleted comment: drop the comment block and keep #245's moved tags. single_function.html merges cleanly with it. Stacked on #263, with no dependency on it.

Closes #260.

static/trace_CFG/lib/jquery-3.1.1.min.js came in with CFGExplorer but was
never loaded. Its only references were script tags inside an HTML comment at
the top of the style block, in templates/single_function.html:6-9 and
templates/result_compare_function_vs.html:6-9.

Nothing else in the repository names the file: not the other templates, the
Python code, the tests, the docs or setup.py, and no script loads it at
runtime (no getScript, importScripts or script element built in JS). The
pages get jQuery 3.6.0 from static/jquery.js through base.html, and
trace_CFG/main.js and main_duo.js use that global $.

This deletes the file (85 KB) and the commented-out block, which also held a
tag for trace_CFG/lib/split.js. split.js is left in place: it is referenced
nowhere else either, but removing it was not part of this change.

Checked with the full test suite and ruff check. The function page and the
function comparison page were also rendered in the test client: they still
load trace_CFG/lib/d3.min.js and no longer contain jquery-3.1.1.
@danielplohmann

Copy link
Copy Markdown
Collaborator

Merged into master via #318 (integration of batch E, merge commit fe6b313): this PR's head is an ancestor of master. It shows as open only because GitHub doesn't let a stacked PR's base be changed to master.

@r0ny123
r0ny123 deleted the fix/drop-jquery-3.1.1 branch October 30, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trace_CFG ships a jQuery 3.1.1 that no page loads

2 participants