Repository navigation
Update jQuery UI to 1.13.3 for CVE-2022-31160 (#257) - #261
Merged
Merged
Conversation
base.html loads static/jquery-ui.js and static/jquery-ui.css on every page, and both were jQuery UI 1.13.1. That release is affected by CVE-2022-31160: checkboxradio reads its label's text nodes back as HTML on refresh, so a label holding escaped markup turns into live markup. 1.13.2 fixed it; 1.13.3 is the last 1.13.x release. Both files are replaced with the unmodified dist files from the jquery-ui 1.13.3 npm package: the full build (same component list as before) and the base theme. The JS diff beyond the version bump is the checkboxradio fix plus small fixes to resizable, selectmenu and the dialog focus workaround for jQuery 3.6. The CSS differs from the old file only in the overlay opacity: the old copy came from the download builder, which wrote .003 instead of .3 for .ui-widget-overlay. Nothing here opens a jQuery UI dialog, so that rule is unused today. The theme references six icon sprites, of which only ui-icons_444444 was ever committed; that was already so with 1.13.1 and nothing here uses the other five, so they are not added. The app itself only calls .sortable() on the cross-comparison sample list; the .tooltip() call in clipboard_js resolves to Bootstrap's plugin, which is registered after jQuery UI's. A browser check of both (drag-reordering plus changeorder(), and the copy button tooltip) and of the family type-ahead behaved the same with 1.13.1 and 1.13.3, with no console errors. The same check confirms the CVE: an escaped <img onerror> in a checkboxradio label runs after refresh with 1.13.1 and stays text with 1.13.3. pytest and ruff pass.
The README conflict is the version history: master folded the older unreleased lines into its 1.6.0 entry, so only this branch's own line stays above it.
This was referenced Oct 19, 2026
r0ny123
added a commit
that referenced
this pull request
Oct 24, 2026
#261 replaces the full build with 1.13.3 for CVE-2022-31160, and the committed cut is checked against whatever full build is vendored. With #261 merged in, the cut is regenerated from 1.13.3, so the branch stays green whichever of the two merges first. Of the kept modules only the banners, version strings and links differ.
danielplohmann
added a commit
that referenced
this pull request
Oct 24, 2026
r0ny123
pushed a commit
to r0ny123/mcritweb
that referenced
this pull request
Oct 30, 2026
Bumps setup.py and adds the version history entry, folding in the five "unreleased" lines (familiary#263, familiary#262, familiary#261, familiary#293, familiary#254). 48 PRs since 1.6.0: batches C1 (familiary#298), C2 (familiary#299), security E (familiary#318), UI F (familiary#339) and fixes G (familiary#340). No dependency changes. The entry leads with the three things that affect existing deployments: instance/ backups under WAL mode, the bounded result cache, and the optional retirement of pre-1.5.0 API tokens. Test count measured on the batch G tree, which master 30cbc8a is identical to: 2428 passed, 19 skipped against mcrit 1.16.0, 2447 collected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HERmVhHo4ibp7HSTXr3Ya8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
static/jquery-ui.jsandjquery-ui.css, whichbase.html:31,36loads on every page, were jQuery UI 1.13.1. That release has CVE-2022-31160 (#257): acheckboxradiowidget reads its label's escaped text back as HTML onrefresh. This replaces both with 1.13.3, the last 1.13.x, taken unmodified from the npm package (dist/jquery-ui.js, the same full build as before, anddist/themes/base/jquery-ui.css).How exposed we were. MCRITweb creates no checkboxradio, so no page of ours reached the flaw. The only jQuery UI widget the app calls is the sortable sample order on the cross compare result (
result_cross.html:72); the.tooltip()intable/links.html:63resolves to Bootstrap's plugin, which registers after jQuery UI. So this is the library on every page being a known-vulnerable version, not a live hole.What else moved from 1.13.1 to 1.13.3. Besides the checkboxradio fix: resizable with
box-sizing: border-box, selectmenu respectinghiddenoptions, and the dialog focus workaround covering jQuery 3.6. None of those widgets are used here. The CSS differs from the old file in one rule: the old copy came from the download builder, which writesopacity: .003for.ui-widget-overlayinstead of.3; that only matters for modal dialogs, which we don't have. The theme references six icon sprites and only one was ever committed, as before; nothing here uses the others, so they're not added.Verification.
<img onerror>in a checkboxradio label, afterrefresh9,11,13,15,…, "Change order" →?custom=9,11,13,15,17,…ruff check .is clean;python -m pytestgives 1258 passed, 7 skipped. The 7 are the Playwright tests, which load the real pages throughbase.html; with Playwright available all 39 tests intestFunctionVsBrowser.pyandtestAutocompleteEscaping.pypass.Relation to open PRs. #126 and #245 move the jQuery UI tags from
base.htmltoresult_cross.html, by the same file names, so they pick this up unchanged; a trial merge with either conflicts only injobs.html, which both already conflict in with master since batch C2; #245'stestPageAssets.pyandtestAssetDiet.pypass with the new files (38 passed). The sizes they quote were measured on 1.13.1; 1.13.3 is 619 bytes larger (529,681 against 529,062), so their figures stay right to the KB.This is the first of four stacked PRs from the same robustness pass (#257, #258, #259, #260); the others build on this branch.
Closes #257.