Bump electron from 40.0.0 to 43.0.0#95
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps [electron](https://github.com/electron/electron) from 40.0.0 to 43.0.0. - [Release notes](https://github.com/electron/electron/releases) - [Commits](electron/electron@v40.0.0...v43.0.0) --- updated-dependencies: - dependency-name: electron dependency-version: 43.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit eed0b1d. Configure here.
| "@tailwindcss/cli": "^4.1.18", | ||
| "canvas-confetti": "^1.9.4", | ||
| "electron": "^40.0.0", | ||
| "electron": "^43.0.0", |
There was a problem hiding this comment.
Stale Electron rebuild target
High Severity
The electron dependency was updated to ^43.0.0, but the rebuild:electron script still targets Electron 40. This causes native modules like better-sqlite3 to be built for the wrong ABI, leading to loading failures or crashes when running the app with Electron 43. This affects start, dev, and test:e2e scripts.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit eed0b1d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Bumps electron from 40.0.0 to 43.0.0.
Release notes
Sourced from electron's releases.
... (truncated)
Commits
5147ac2test: fix lost-event race in custom-protocol-panel devtools fixture (#52194)765def3ci: improve lint job code reuse (#52180)07f9757fix: remove 1px frame background color from the top of frameless windows on L...2e29d7fbuild: register Electron.app with LaunchServices before macOS tests (#52186)3a77e4afix: inherit iframe sandbox flags in windows opened on the OpenURL navigation...3846728chore: bump chromium to 150.0.7871.46 (43-x-y) (#52123)c0d5334ci: calculate rerun apply patches date from first run attempt (#52075)4a2ff4bbuild: only run gn-typescript-definitions for default toolchain (#52165)c3d3305chore: cherry-pick 1 changes from chromium (#52168)dad4f73fix: use the registering session for ProtocolResponse.url requests (#52131)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Medium Risk
Major Electron upgrades affect the entire desktop shell (Chromium/Node ABI, downloads, and possible breaking API behavior). The unchanged
rebuild:electrontarget (40.0.0) risks native module mismatch until aligned with 43.Overview
Bumps the dev dependency
electronfrom 40 to 43 inpackage.jsonand refreshespackage-lock.json(root package version 0.0.70).The lockfile reflects Electron’s newer install stack:
@electron/getv5,@electron-internal/extract-zipinstead ofextract-zip, optionalundici, and a Node ≥22.12 requirement for downloading/installing Electron. Several transitive packages tied to the old download path (e.g.global-agent,got,yauzl) drop out of the tree;semveris consolidated at 7.8.5 in places that previously nested 7.7.3.This is a major Electron jump (Chromium/Node/V8 upgrades per upstream release notes), so runtime and packaging behavior can change even though application source is untouched in this diff.
rebuild:electronstill setsnpm_config_target=40.0.0forbetter-sqlite3; that script was not updated in this PR and may need to match 43.0.0 for native rebuilds against the new runtime.Reviewed by Cursor Bugbot for commit eed0b1d. Bugbot is set up for automated code reviews on this repo. Configure here.