Skip to content

feat: Add requester as an argument to the third party callback check_event_allowed#276

Merged
jason-famedly merged 2 commits into
masterfrom
jason/check-event-allowed-requester
Jul 23, 2026
Merged

feat: Add requester as an argument to the third party callback check_event_allowed#276
jason-famedly merged 2 commits into
masterfrom
jason/check-event-allowed-requester

Conversation

@jason-famedly

@jason-famedly jason-famedly commented Jul 20, 2026

Copy link
Copy Markdown
Member

Backwards compatibility is maintained for previous versions of the callback that did not have this third argument, which allows for graceful migration when the module it is intended for is updated.

Docs updated to reflect new behavior

@jason-famedly
jason-famedly requested a review from a team as a code owner July 20, 2026 18:13
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@79491c4). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...api/callbacks/third_party_event_rules_callbacks.py 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #276   +/-   ##
=========================================
  Coverage          ?   80.44%           
=========================================
  Files             ?      502           
  Lines             ?    72416           
  Branches          ?    10911           
=========================================
  Hits              ?    58257           
  Misses            ?    10871           
  Partials          ?     3288           
Files with missing lines Coverage Δ
synapse/handlers/federation.py 49.60% <ø> (ø)
synapse/handlers/message.py 79.89% <ø> (ø)
...api/callbacks/third_party_event_rules_callbacks.py 68.51% <84.61%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79491c4...131b13d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nico-famedly

Copy link
Copy Markdown
Member

Commit description should say "Add requester as an argument to...". "New argument" doesn't say much.

Comment thread docs/modules/third_party_rules_callbacks.md Outdated
@jason-famedly jason-famedly changed the title feat: Add new argument to the third party callback check_event_allowed feat: Add requester as an argument to the third party callback check_event_allowed Jul 21, 2026
Comment thread synapse/module_api/callbacks/third_party_event_rules_callbacks.py
@jason-famedly
jason-famedly enabled auto-merge July 23, 2026 10:12
@jason-famedly
jason-famedly added this pull request to the merge queue Jul 23, 2026
Merged via the queue into master with commit 887a6c9 Jul 23, 2026
28 of 29 checks passed
@jason-famedly
jason-famedly deleted the jason/check-event-allowed-requester branch July 23, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants