Syk/only one jwk at a time - #102
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
- Coverage 77.71% 77.26% -0.46%
==========================================
Files 13 13
Lines 875 884 +9
Branches 157 160 +3
==========================================
+ Hits 680 683 +3
- Misses 123 126 +3
- Partials 72 75 +3
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
itsoyou
force-pushed
the
syk/only-one-jwk-at-a-time
branch
from
September 2, 2026 11:51
b77c8e1 to
95c433a
Compare
Member
Author
|
I will scope out the Docs change that is unrelated to jwk/enc_jwk topic into separate PR. |
FrenchGithubUser
previously approved these changes
Sep 3, 2026
FrenchGithubUser
left a comment
Member
There was a problem hiding this comment.
looks good to me, might want to squash before merging :)
itsoyou
force-pushed
the
syk/refactor-config
branch
from
September 4, 2026 12:36
8e4cdfd to
12545c3
Compare
itsoyou
dismissed
FrenchGithubUser’s stale review
September 4, 2026 12:50
The base branch was changed.
itsoyou
force-pushed
the
syk/only-one-jwk-at-a-time
branch
from
September 4, 2026 13:14
5b536b9 to
62451f5
Compare
FrenchGithubUser
approved these changes
Sep 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SYN-117
rendered
Note
Medium Risk
Stricter config validation can break deployments that previously set multiple JWK options; behavior is clearer but may require config cleanup on upgrade.
Overview
Enforces mutually exclusive JWK configuration so deployers cannot specify overlapping key sources that were previously ambiguous.
Runtime validation in
EPaConfigandJwtValidationConfignow requires exactly one of: inline JWK/JWKSet, PEM file path, or JWKS URL. Setting two or more (e.g.jwk_setplusjwks_endpoint, orenc_jwkplusenc_jwk_file) raises aValidationErrorat startup instead of silently picking one path.Documentation in
README.mdis reorganized (JWT/OIDC/ePA sections, shared “Types” for validators/paths/auth) and states these exclusivity rules explicitly, including newJwtConfig/OIDCConfigtables andcheck_external_idon OAuth.Tests cover invalid combinations for ePA encryption keys and signing/JWKS sources.
Reviewed by Cursor Bugbot for commit 95c433a. Bugbot is set up for automated code reviews on this repo. Configure here.