feat(formatting): Add shfmt#47
Conversation
Upstreamed from another Famedly repository, so you know these formatter options are popular.
PR SummaryLow Risk Overview
Reviewed by Cursor Bugbot for commit 6651153. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.
Reviewed by Cursor Bugbot for commit 6651153. Configure here.
| # Setting the indent_size to 0 uses tabs for indentation | ||
| indent_size = 0; | ||
| }; | ||
| settings.formatter.shfmt.command = "shfmt"; |
There was a problem hiding this comment.
Missing simplify in Nix config
Medium Severity
Issue: treefmt.toml enables shfmt -s, but programs.shfmt only sets indent_size and never enables simplify (or equivalent settings.formatter.shfmt.options). Since treefmt.toml is generated from Nix via filegen, the next apply will drop -s or fail the prek filegen check.
Fix: Enable simplify in the Nix source of truth (e.g. programs.shfmt.simplify = true, or append "-s" the same way nixfmt sets "--strict"), then regenerate treefmt.toml.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 6651153. Configure here.


Upstreamed from another Famedly repository, so you know these formatter options are popular.