ci: require the macOS build again now that macos.rs compiles#18
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables macOS as a gating CI signal now that the Rust macOS build compiles again, to prevent regressions across all supported platforms.
Changes:
- Update CI documentation comment to reflect that macOS builds are expected to pass again.
- Make the macOS matrix leg non-optional by setting
allow-failure: false(thuscontinue-on-error: false) for macOS.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+31
to
+33
| # Cross-platform Rust compile signal. All three platforms must pass: | ||
| # windows/linux are this fork's release targets, and macOS compiles again | ||
| # since the PanelHandle port (#16, fixed #17). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #16 / #17: the macOS leg compiles green now, so make it a required check again to prevent regressions. Comment updated to reflect reality.
🤖 Generated with Claude Code