Skip to content

feat(finance): transform to standalone modular functions - #4073

Open
ST-DDT wants to merge 5 commits into
nextfrom
feat/smf/finance
Open

ST-DDT wants to merge 5 commits into
nextfrom
feat/smf/finance

Conversation

@ST-DDT

@ST-DDT ST-DDT commented Sep 6, 2026

Copy link
Copy Markdown
Member

Continuation of #4056


Transforms the finance module to standalone modular functions.


This PR can be recreated using the following steps:

  1. Checkout next/previous SMF PR
  2. Run pnpm tsx scripts/temp-transform-once.ts finance
  3. Cherry-pick refactor: transform finance module
  4. Cherry-pick chore: allow module
  5. Run pnpm run generate:module-tree
  6. Cherry-pick chore: remove temp exports

@ST-DDT ST-DDT added this to the v11.0 milestone Sep 6, 2026
@ST-DDT ST-DDT self-assigned this Sep 6, 2026
@ST-DDT
ST-DDT requested a review from a team as a code owner September 6, 2026 21:21
@ST-DDT ST-DDT added c: feature Request for new feature p: 1-normal Nothing urgent m: finance Something is referring to the finance module labels Sep 6, 2026
@netlify

netlify Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 854794a
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/6aaefd387fe898000856c7d7
😎 Deploy Preview https://deploy-preview-4073.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@ST-DDT
ST-DDT marked this pull request as draft September 6, 2026 21:21
@ST-DDT

ST-DDT commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

Blocked by #3985 to avoid conflicts.

@ST-DDT ST-DDT changed the title feat(finance): transform to standalone modular functions - #4056 feat(finance): transform to standalone modular functions Sep 6, 2026
@codecov

codecov Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.17%. Comparing base (4f8a9ef) to head (854794a).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4073      +/-   ##
==========================================
+ Coverage   99.16%   99.17%   +0.01%     
==========================================
  Files        1152     1171      +19     
  Lines        3827     3876      +49     
  Branches      683      691       +8     
==========================================
+ Hits         3795     3844      +49     
  Misses         28       28              
  Partials        4        4              
Files with missing lines Coverage Δ
src/modules/finance/_iban-lib.ts 100.00% <100.00%> (ø)
src/modules/finance/account-name.ts 100.00% <100.00%> (ø)
src/modules/finance/account-number.ts 100.00% <100.00%> (ø)
src/modules/finance/amount.ts 100.00% <100.00%> (ø)
src/modules/finance/bic.ts 100.00% <100.00%> (ø)
src/modules/finance/bitcoin-address.ts 100.00% <100.00%> (ø)
src/modules/finance/credit-card-cvv.ts 100.00% <100.00%> (ø)
src/modules/finance/credit-card-issuer.ts 100.00% <100.00%> (ø)
src/modules/finance/credit-card-number.ts 100.00% <100.00%> (ø)
src/modules/finance/currency-code.ts 100.00% <100.00%> (ø)
... and 13 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ST-DDT
ST-DDT marked this pull request as ready for review September 19, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: feature Request for new feature m: finance Something is referring to the finance module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants