Skip to content

Optimize Emscripten REST long-poll requests #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drslebedev merged 2 commits into from
Sep 3, 2026
Merged

Optimize Emscripten REST long-poll requests #410

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5dfb7b
RestClient: avoid CORS preflights for Emscripten GETs
drslebedev Sep 3, 2026
5d8c086
RestClient: bypass IndexedDB for Emscripten fetches
drslebedev Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/client/include/RestClientEmscripten.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,19 +191,22 @@ struct RestWorkerState {
if (const auto entry = query.find("contentType"); entry != query.end() && entry->second) {
contentType = *entry->second;
}
const std::array<const char *, 5> headers{ "accept", contentType.c_str(), "content-type", contentType.c_str(), nullptr };

const std::string_view method = activeFetch->command.has_value() && activeFetch->command->command == mdp::Command::Set ? "POST" : "GET";
const std::string_view method = activeFetch->command.has_value() && activeFetch->command->command == mdp::Command::Set ? "POST" : "GET";
std::array<const char *, 5> headers{ "accept", contentType.c_str(), nullptr, nullptr, nullptr };
if (method == "POST") {
headers[2] = "content-type";
headers[3] = contentType.c_str();
}

emscripten_fetch_attr_t attr;
emscripten_fetch_attr_t attr;
emscripten_fetch_attr_init(&attr);
method.copy(attr.requestMethod, method.size());
attr.requestMethod[method.size()] = '\0';
attr.attributes = EMSCRIPTEN_FETCH_LOAD_TO_MEMORY;
attr.requestHeaders = headers.data();
attr.onsuccess = &RestWorkerState::onFetchSuccess;
attr.onerror = &RestWorkerState::onFetchError;
attr.userData = activeFetch.get();
attr.attributes = EMSCRIPTEN_FETCH_LOAD_TO_MEMORY | EMSCRIPTEN_FETCH_REPLACE;
attr.requestHeaders = headers.data();
attr.onsuccess = &RestWorkerState::onFetchSuccess;
attr.onerror = &RestWorkerState::onFetchError;
attr.userData = activeFetch.get();
if (!activeFetch->body.empty()) {
attr.requestData = activeFetch->body.data();
attr.requestDataSize = activeFetch->body.size();
Expand Down
Loading