feat: keep incoming deleted messages visible locally#27
Open
rhcp011235 wants to merge 1 commit into
Open
Conversation
Messages deleted by other users are no longer removed from the local message list, so they remain visible to the local client. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
confirmed this to work as well |
Contributor
|
The PR only demonstrates the concept but would need substantially more work to be a proper feature:
I would not merge this PR as-is. It's more of a |
eacfa46 to
25aba81
Compare
9830d37 to
56f34ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation
Modified
processMessagesDeleted()andprocessNonChannelMessagesDeleted()indata_session.cppto skipdestroy()for any message whereitem->out()returns false.Test plan
🤖 Generated with Claude Code