Skip to content

feat: keep incoming deleted messages visible locally#27

Open
rhcp011235 wants to merge 1 commit into
fagramdesktop:devfrom
rhcp011235:feature/anti-delete-clean
Open

feat: keep incoming deleted messages visible locally#27
rhcp011235 wants to merge 1 commit into
fagramdesktop:devfrom
rhcp011235:feature/anti-delete-clean

Conversation

@rhcp011235
Copy link
Copy Markdown
Contributor

Summary

  • Messages deleted by other users no longer disappear from the local message list
  • Only outgoing messages (sent by the local user) are removed when a delete event is received
  • Incoming messages from other users survive deletion updates and remain visible

Implementation

Modified processMessagesDeleted() and processNonChannelMessagesDeleted() in data_session.cpp to skip destroy() for any message where item->out() returns false.

Test plan

  • Have another user delete a message in a shared chat — confirm it stays visible on your end
  • Delete one of your own messages — confirm it still disappears normally
  • Test in both regular chats and channels

🤖 Generated with Claude Code

Messages deleted by other users are no longer removed from the local
message list, so they remain visible to the local client.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@rhcp011235
Copy link
Copy Markdown
Contributor Author

confirmed this to work as well

@Burhanverse
Copy link
Copy Markdown
Contributor

The PR only demonstrates the concept but would need substantially more work to be a proper feature:

  • A settings toggle in FAgram settings
  • Visual indication of deleted messages
  • Proper handling of the historiesToCheck logic that gets skipped
  • Ideally, local persistence so anti-deleted messages survive restarts

I would not merge this PR as-is. It's more of a proof-of-concept than a complete feature implementation.

@Burhanverse Burhanverse force-pushed the dev branch 7 times, most recently from eacfa46 to 25aba81 Compare April 12, 2026 16:41
@Burhanverse Burhanverse force-pushed the dev branch 2 times, most recently from 9830d37 to 56f34ea Compare May 22, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants