Fix built-in functions being double-counted as regular tags - #8
Draft
fafouine wants to merge 1 commit into
Draft
Conversation
The regular-tag pattern #(\w+) also matches the name inside a built-in such as #print(), so #print() was counted both in the built-ins index and as a regular #print tag. After extracting methods and built-ins, drop any regular tag whose name was already captured as a method or built-in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
scripts/generate_tag_index.py, the regular-tag pattern#(\w+)also matches the name inside a built-in such as#print(). Because#(\w+)\(\)(built-ins) and#(\w+)(regular tags) both scan the same text,#print()was captured by both — soprintshowed up in the built-ins index and as a regular#printtag, producing duplicate/misleading entries (and its generatedprint.mdpage was overwritten).Fix
After extracting methods and built-ins, drop any regular tag whose name was already captured as a method or built-in:
Verification
#print() #len() #.append() #python #Web_Security, the original code returnsregular_tags = ['print', 'len', 'python', 'Web_Security'].regular_tags = ['python', 'Web_Security'];built_ins = ['print', 'len'];methods = ['append', 'split'].#print()/#len()now appear only under Built-in Functions and no longer under Tags intags/index.md. Temporary sample/generated files were removed so this PR contains only the one-file change.Task & docs