Make MediaWiki MLP jobs tunable + add reportable tuned preset (#702)#702
Open
charles-typ wants to merge 1 commit into
Open
Make MediaWiki MLP jobs tunable + add reportable tuned preset (#702)#702charles-typ wants to merge 1 commit into
charles-typ wants to merge 1 commit into
Conversation
|
@charles-typ has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110121020. |
…okresearch#702) Summary: Problem: MediaWiki tuning sweeps on Phoenix (NUMA-1) appeared to produce "no valid result" in benchpress. The runs themselves were fine -- they produced metrics JSON + mpstat artifacts -- but they were launched under custom job names (mw_mlp_r1_tuned, mw_mlp_r1_c512, mw_mlp_r3_tuned) via a local -j jobs file. `benchpress report <name>` returns "No job found" for unregistered names, so those results never rolled into the DCPerf geomean. From the reporting tool's view, the data did not exist. Why: The registered oss_performance_mediawiki_mlp* jobs only template scale_out (-R) and client_threads (-c). To vary server_threads (-t) or memcache_threads (-m) -- needed for the R1/t400 single-large-HHVM variant -- users had to fork the job under a new name, orphaning the result from report/geomean. Fix: - Add -t{server_threads} and -m{memcache_threads} to the registered oss_performance_mediawiki_mlp, _mlp_no_jit, and _mem jobs. New vars default to 0, which run.sh already interprets as "use computed default", so stock behavior is unchanged (verified: stock _mlp still expands to R2/t200/c256 on a 128-core host). - Add a new registered preset oss_performance_mediawiki_mlp_tuned (R1/t400/c256/m64) capturing the best-performing tuning variant, so it reports + rolls into the geomean like any first-class job. - run.sh: guard -m0 to fall back to the computed default, matching the existing -R0/-t0/-c0 guards. Differential Revision: D110121020
981bd42 to
c17182d
Compare
meta-codesync Bot
pushed a commit
that referenced
this pull request
Jun 30, 2026
Summary: Pull Request resolved: #702 Problem: MediaWiki tuning sweeps on Phoenix (NUMA-1) appeared to produce "no valid result" in benchpress. The runs themselves were fine -- they produced metrics JSON + mpstat artifacts -- but they were launched under custom job names (mw_mlp_r1_tuned, mw_mlp_r1_c512, mw_mlp_r3_tuned) via a local -j jobs file. `benchpress report <name>` returns "No job found" for unregistered names, so those results never rolled into the DCPerf geomean. From the reporting tool's view, the data did not exist. Why: The registered oss_performance_mediawiki_mlp* jobs only template scale_out (-R) and client_threads (-c). To vary server_threads (-t) or memcache_threads (-m) -- needed for the R1/t400 single-large-HHVM variant -- users had to fork the job under a new name, orphaning the result from report/geomean. Fix: - Add -t{server_threads} and -m{memcache_threads} to the registered oss_performance_mediawiki_mlp, _mlp_no_jit, and _mem jobs. New vars default to 0, which run.sh already interprets as "use computed default", so stock behavior is unchanged (verified: stock _mlp still expands to R2/t200/c256 on a 128-core host). - Add a new registered preset oss_performance_mediawiki_mlp_tuned (R1/t400/c256/m64) capturing the best-performing tuning variant, so it reports + rolls into the geomean like any first-class job. - run.sh: guard -m0 to fall back to the computed default, matching the existing -R0/-t0/-c0 guards. Reviewed By: YifanYuan3 Differential Revision: D110121020 fbshipit-source-id: 76375b6cc79ffcbea38b159a34a8380da0b3ac59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Problem: MediaWiki tuning sweeps on Phoenix (NUMA-1) appeared to produce
"no valid result" in benchpress. The runs themselves were fine -- they
produced metrics JSON + mpstat artifacts -- but they were launched under
custom job names (mw_mlp_r1_tuned, mw_mlp_r1_c512, mw_mlp_r3_tuned) via a
local -j jobs file.
benchpress report <name>returns "No job found" forunregistered names, so those results never rolled into the DCPerf geomean.
From the reporting tool's view, the data did not exist.
Why: The registered oss_performance_mediawiki_mlp* jobs only template
scale_out (-R) and client_threads (-c). To vary server_threads (-t) or
memcache_threads (-m) -- needed for the R1/t400 single-large-HHVM variant --
users had to fork the job under a new name, orphaning the result from
report/geomean.
Fix:
oss_performance_mediawiki_mlp, _mlp_no_jit, and _mem jobs. New vars
default to 0, which run.sh already interprets as "use computed default",
so stock behavior is unchanged (verified: stock _mlp still expands to
R2/t200/c256 on a 128-core host).
(R1/t400/c256/m64) capturing the best-performing tuning variant, so it
reports + rolls into the geomean like any first-class job.
existing -R0/-t0/-c0 guards.
Differential Revision: D110121020