Add self-contained FeedSim fbpkg build via buck_genrule (#685)#685
Open
excelle08 wants to merge 1 commit into
Open
Add self-contained FeedSim fbpkg build via buck_genrule (#685)#685excelle08 wants to merge 1 commit into
excelle08 wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@excelle08 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93702226. |
…arch#685) Summary: Pre-build FeedSim at fbpkg build time so the package runs without `benchpress install`. Both x86_64 and aarch64 use the same two-stage offline build: 1. `feedsim_deps_download` — runs on x86 with network, downloads source tarballs and pre-packed conda env from Manifold 2. `feedsim_oss_build[_aarch64]` — runs on arch-specific RE host, extracts conda env (GCC 15.2, cmake, ninja), builds all deps from source, compiles FeedSim with DLRM support Key changes: - `build.sh`: standalone build script — extracts pre-packed conda env, builds Boost/gflags/glog/jemalloc/libevent/folly/fbthrift, compiles FeedSim - `download_deps.sh`: downloads from Manifold (no internet fallback needed) - BUCK: three genrules (deps_download, x86 build, aarch64 build) with `select()` in fbpkg path_actions for architecture dispatch - CMake: pass-through CMAKE_PREFIX_PATH for staging dir in ExternalProject - `run.sh`/`run-feedsim-multi.sh`: LD_LIBRARY_PATH for conda runtime libs Performance (feedsim_autoscale, 3 iterations each): - x86 Bergamo: 395.20 QPS self-contained vs 380.92 QPS master (+3.7%) - ARM Grace: 324.57 QPS self-contained vs 322.48 QPS master (+0.6%) Reviewed By: gandhijayneel Differential Revision: D93702226
meta-codesync
Bot
changed the title
excelle08
force-pushed
the
export-D93702226-to-v2-beta
branch
from
fdb6b63 to
983faaa
Compare
excelle08
added a commit
to excelle08/DCPerf-1
that referenced
this pull request
Jun 25, 2026
…arch#685) Summary: Pre-build FeedSim at fbpkg build time so the package runs without `benchpress install`. Both x86_64 and aarch64 use the same two-stage offline build: 1. `feedsim_deps_download` — runs on x86 with network, downloads source tarballs and pre-packed conda env from Manifold 2. `feedsim_oss_build[_aarch64]` — runs on arch-specific RE host, extracts conda env (GCC 15.2, cmake, ninja), builds all deps from source, compiles FeedSim with DLRM support Key changes: - `build.sh`: standalone build script — extracts pre-packed conda env, builds Boost/gflags/glog/jemalloc/libevent/folly/fbthrift, compiles FeedSim - `download_deps.sh`: downloads from Manifold (no internet fallback needed) - BUCK: three genrules (deps_download, x86 build, aarch64 build) with `select()` in fbpkg path_actions for architecture dispatch - CMake: pass-through CMAKE_PREFIX_PATH for staging dir in ExternalProject - `run.sh`/`run-feedsim-multi.sh`: LD_LIBRARY_PATH for conda runtime libs Performance (feedsim_autoscale, 3 iterations each): - x86 Bergamo: 395.20 QPS self-contained vs 380.92 QPS master (+3.7%) - ARM Grace: 324.57 QPS self-contained vs 322.48 QPS master (+0.6%) Reviewed By: gandhijayneel Differential Revision: D93702226
meta-codesync Bot
pushed a commit
that referenced
this pull request
Jun 25, 2026
Summary: Pull Request resolved: #685 Pre-build FeedSim at fbpkg build time so the package runs without `benchpress install`. Both x86_64 and aarch64 use the same two-stage offline build: 1. `feedsim_deps_download` — runs on x86 with network, downloads source tarballs and pre-packed conda env from Manifold 2. `feedsim_oss_build[_aarch64]` — runs on arch-specific RE host, extracts conda env (GCC 15.2, cmake, ninja), builds all deps from source, compiles FeedSim with DLRM support Key changes: - `build.sh`: standalone build script — extracts pre-packed conda env, builds Boost/gflags/glog/jemalloc/libevent/folly/fbthrift, compiles FeedSim - `download_deps.sh`: downloads from Manifold (no internet fallback needed) - BUCK: three genrules (deps_download, x86 build, aarch64 build) with `select()` in fbpkg path_actions for architecture dispatch - CMake: pass-through CMAKE_PREFIX_PATH for staging dir in ExternalProject - `run.sh`/`run-feedsim-multi.sh`: LD_LIBRARY_PATH for conda runtime libs Performance (feedsim_autoscale, 3 iterations each): - x86 Bergamo: 395.20 QPS self-contained vs 380.92 QPS master (+3.7%) - ARM Grace: 324.57 QPS self-contained vs 322.48 QPS master (+0.6%) Reviewed By: gandhijayneel Differential Revision: D93702226 fbshipit-source-id: 0fee00eb5af8c0f771905d2870f75cf3b75b3720
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Pre-build FeedSim at fbpkg build time so the package runs without
benchpress install. Both x86_64 and aarch64 use the same two-stageoffline build:
feedsim_deps_download— runs on x86 with network, downloads sourcetarballs and pre-packed conda env from Manifold
feedsim_oss_build[_aarch64]— runs on arch-specific RE host, extractsconda env (GCC 15.2, cmake, ninja), builds all deps from source, compiles
FeedSim with DLRM support
Key changes:
build.sh: standalone build script — extracts pre-packed conda env,builds Boost/gflags/glog/jemalloc/libevent/folly/fbthrift, compiles FeedSim
download_deps.sh: downloads from Manifold (no internet fallback needed)select()in fbpkg path_actions for architecture dispatchrun.sh/run-feedsim-multi.sh: LD_LIBRARY_PATH for conda runtime libsPerformance (feedsim_autoscale, 3 iterations each):
Reviewed By: gandhijayneel
Differential Revision: D93702226