Add pidstat post-processing to cpu-pidstat after_job#680
Open
aashvibusa wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@aashvibusa has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107678812. |
Summary: Move the per-thread-pool CSV post-processing into the cpu-pidstat hook instead of adding a duplicate pidstat perf monitor. after_job now parses the raw `pidstat -t -h` log the hook already collects and writes a per-thread-pool CSV (count + avg/min/max/var per metric) next to the log. breakdown_keys / stats / normalize_thread_names are configurable via hook options and validated in before_job; post-processing failures are logged and never break teardown. Differential Revision: D107678812
meta-codesync
Bot
changed the title
aashvibusa
force-pushed
the
export-D107678812-to-v2-beta
branch
from
40269c5 to
67495b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Move the per-thread-pool CSV post-processing into the cpu-pidstat hook instead
of adding a duplicate pidstat perf monitor. after_job now parses the raw
pidstat -t -hlog the hook already collects and writes a per-thread-pool CSV(count + avg/min/max/var per metric) next to the log. breakdown_keys / stats /
normalize_thread_names are configurable via hook options and validated in
before_job; post-processing failures are logged and never break teardown.
Differential Revision: D107678812