Unbreak fbclock's Go build under clang 21 (#581) - #581
Open
leoleovich wants to merge 1 commit into
Open
leoleovich wants to merge 1 commit into
leoleovich wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@leoleovich has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120272839. |
Summary:
`buck2 test //time/fbclock/...` does not build on master: fbclock's Go tests, daemon and sidecar are all unbuildable.
cgo: fbclock.go:72:13: unexpected type: (unsupported type AtomicType)
Clang 21 emits `DW_TAG_atomic_type` where clang 19 folded the atomic into its base integer. cgo reads DWARF, and Go's `debug/dwarf` cannot model that tag, so every struct reachable from `fbclock_lib` fails to convert.
Go never touches `seq` or `crc`, so only the cgo preamble now sees the plain base type. `fbclock.c` keeps the real atomics and static_asserts that the layout matches.
Sentinel-Council-Run: council_1789520658_fbd80dac
Sentinel-Council-Run: council_1789531426_e0c09b3e
Sentinel-Council-Run: council_1789538610_83d8818c
Sentinel-Harness: claude
*Modify your team agent prompt, check stats, and leave feedback: https://www.internalfb.com/sentinel_agent/rotations/clock*
Model used: Claude Opus 5 (claude-opus-5[1m])
Differential Revision: D120272839
meta-codesync
Bot
changed the title
leoleovich
force-pushed
the
export-D120272839
branch
from
September 16, 2026 09:31
181c5e8 to
744e901
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
buck2 test //time/fbclock/...does not build on master: fbclock's Go tests, daemon and sidecar are all unbuildable.Clang 21 emits
DW_TAG_atomic_typewhere clang 19 folded the atomic into its base integer. cgo reads DWARF, and Go'sdebug/dwarfcannot model that tag, so every struct reachable fromfbclock_libfails to convert.Go never touches
seqorcrc, so only the cgo preamble now sees the plain base type.fbclock.ckeeps the real atomics and static_asserts that the layout matches.Sentinel-Council-Run: council_1789520658_fbd80dac
Sentinel-Council-Run: council_1789531426_e0c09b3e
Sentinel-Council-Run: council_1789538610_83d8818c
Sentinel-Harness: claude
Modify your team agent prompt, check stats, and leave feedback: https://www.internalfb.com/sentinel_agent/rotations/clock
Model used: Claude Opus 5 (claude-opus-5[1m])
Differential Revision: D120272839